-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.0.0 and v6.0.0 Release Target #1302
Labels
Milestone
Comments
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to the already large size of the v4.0.0 release, I'm going to move some of the targeted changes for the v5.0.0 release target instead.
v5.0.0 Release Target
Improved
@react-md/menu
APIA new and improved
@react-md/menu
API. Instead of passing a list ofitems
, directly use the<MenuItem>
components within the children.These changes make it so that you can now create resuable components to handle specific actions. i.e.
Additional changes:
v6.0.0 Release Target
Improved
Select
API and BehaviorWhat I'm mostly trying to accomplish with these changes are:
onChange={(value) => setValue(value as SomeTypeUnion)}
Select
to handle validation like theTextField
andTextArea
componentsrequired
behavior to start workingThe
Select
component will now render an invisible<select>
element and all the<option>
s instead of using an<input type="hidden" value={CURRENT_VALUE} />
. This change makes it so that theSelect
component can now correctly handle form validation.I'm still working out the API, but I think it'll mimic the new
Menu
API since it follows how you'd use a native<select>
and allows for elements to be rendered without first creating a list of options:Another alternative is something like this (less preferred now):
Quick video example of changes:
Screen.Recording.2021-11-24.at.12.30.20.PM.mov
Remove
@react-md/autocomplete
packageWith all the new
Select
changes listed above, I think it would be better just to integrate theAutoComplete
component into the@react-md/form
package with a newuseAutoComplete
hook andAutoComplete
component.The text was updated successfully, but these errors were encountered: