Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min within task to the various printouts #156

Open
mlb2251 opened this issue Nov 24, 2022 · 0 comments
Open

add min within task to the various printouts #156

mlb2251 opened this issue Nov 24, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@mlb2251
Copy link
Owner

mlb2251 commented Nov 24, 2022

This only could affect claim-1 results and none of those results are messed up in this way bc we didnt use these values, but we should make the following printouts and values also use min:

  • analyze first_train_cost a bit, it's weird shouldnt it min within a task like the other?
  • note that current compression_ratio stuff is also not task aware
  • original_cost also uses the non-min cost
  • likewise with the integration_tests version of origimal_cost
@mlb2251 mlb2251 added the bug Something isn't working label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant