Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add vision model flag to model record #3031

Open
Neet-Nestor opened this issue Nov 16, 2024 · 1 comment
Open

[Feature Request] Add vision model flag to model record #3031

Neet-Nestor opened this issue Nov 16, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@Neet-Nestor
Copy link
Contributor

Neet-Nestor commented Nov 16, 2024

🚀 Feature

Add a field to the ModelRecord to indicate whether a model is a vision model like Phi-vision models.

 data class ModelRecord(
    @SerializedName("model_url") val modelUrl: String,
    @SerializedName("model_id") val modelId: String,
    @SerializedName("estimated_vram_bytes") val estimatedVramBytes: Long?,
    @SerializedName("model_lib") val modelLib: String
)

Motivation

Users and apps need to have additional UI and functionality for vision models for picking and loading images. Currently there is no way to retrieve the information from the config files as the information is missing.

Alternatives

Otherwise, the users could hardcode UI for specific models.

Additional context

I'm trying to add UI for iOS app of the MLC-LLM for Phi-vision models.

@Neet-Nestor Neet-Nestor added the feature request New feature or request label Nov 16, 2024
@YangWang92
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants