Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default linesearch to Hager-Zhang #172

Merged
merged 10 commits into from
Dec 5, 2023
Merged

Change default linesearch to Hager-Zhang #172

merged 10 commits into from
Dec 5, 2023

Conversation

sethaxen
Copy link
Member

@sethaxen sethaxen commented Dec 5, 2023

Implements #64 . This is technically a breaking change and is marked as such

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67b90cf) 93.42% compared to head (5f8e3c4) 92.92%.

❗ Current head 5f8e3c4 differs from pull request most recent head 1cfd012. Consider uploading reports for the commit 1cfd012 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   93.42%   92.92%   -0.50%     
==========================================
  Files          13       13              
  Lines         593      594       +1     
==========================================
- Hits          554      552       -2     
- Misses         39       42       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethaxen sethaxen changed the title Change to default Hager-Zhang linesearch Change default linesearch to Hager-Zhang Dec 5, 2023
@sethaxen sethaxen merged commit 2f8e8df into main Dec 5, 2023
11 of 12 checks passed
@sethaxen sethaxen deleted the hagherzhangls branch December 5, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant