-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved configuration parsing #758
Comments
Hi @sarthakpati can you please assign this issue to me. |
Thanks, done. |
Stale issue message |
Stale issue message |
Hi @vedik2002, are you still working on this? |
Stale issue message |
Hey @vedik2002 are you still working on this? |
Hi @sarthakpati can please remove me from this issue. |
Here are a few viable alternatives to our current configuration management system:
Did you have something else in mind, @VukW? |
I'd prefer to stick to pydantic models (BaseModel, BaseSettings) as they actually give the same experience and simplicity as dataclass but with additional handy tools like custom fields validation, runtime type checking, etc |
@sarthakpati yes, exactly |
Cool, thanks. 👍🏽 |
Stale issue message |
Hi @sarthakpati could you please assign this issue to me. |
Is your feature request related to a problem? Please describe.
Currently, the configuration parsing is done by a single submodule [ref], which is creates issues with maintenance as more functionality is introduced.
Describe the solution you'd like
Using a configuration validation mechanism that is more standardized would make the developer and user experience much better. Some examples are (and this is by no means an exhaustive list):
Describe alternatives you've considered
N.A.
Additional context
It would make sense to eventually move GaNDLF's various functionalities to something like Hydra, and this could potentially be a good starting point.
The text was updated successfully, but these errors were encountered: