Make is_cpu_op default to False in ETFeeder
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update is_cpu_op to default to false
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
|
This PR makes sense to me and also solves the problem mentioned in this PR (#159) |
|
Looks good to me! Fixes downstream issues in Astra-sim |
tushar-krishna
approved these changes
Jan 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At least in ASTRA-sim, only Chakra nodes with
is_cpu_opset to False will be simulated. Given the objective of the Chakra (capturing distributed ML workloads), it seems it makes more sense to setis_cpu_opFalse by default when reading a Chakra node in ETFeeder: when it is not explicitly set to True.