Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang-format version 10 #10

Closed
mcharleb opened this issue Aug 5, 2021 · 3 comments · Fixed by #13
Closed

Use clang-format version 10 #10

mcharleb opened this issue Aug 5, 2021 · 3 comments · Fixed by #13
Assignees
Labels
type:enhancement New feature or request

Comments

@mcharleb
Copy link
Contributor

mcharleb commented Aug 5, 2021

We can see formatting differences between different versions of clang-format. Update CI to use version10 (Ubuntu 18.04 default version).

@mcharleb mcharleb added this to the Initial External Code Release milestone Aug 5, 2021
@freedomtan freedomtan added the type:enhancement New feature or request label Aug 7, 2021
@bellycat77
Copy link
Contributor

@mcharleb @relja128 Why should we use clang-format version 10?
We have no mentions of it in our README. Also, we have no mentions of Ubuntu 18.04.
Users can have Debian as the host system, for example. Or even MacOS. clang-format is a part of the host system in our case...

@bellycat77
Copy link
Contributor

The default version of clang-format used in Ubuntu is 6.0. I mean Ubuntu in Docker-image, but version 10 is available too (as separate package)

@bellycat77
Copy link
Contributor

So in our case, we could try to use clang-format from our Docker image (we need to modify the docker image and add the required version of clang-format )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants