Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understanding MP policy for parameters #288

Open
rphlstck opened this issue Jan 24, 2024 · 0 comments
Open

Understanding MP policy for parameters #288

rphlstck opened this issue Jan 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rphlstck
Copy link

Hey,

first of all, thank you for the nice work!
I have a question regarding the fixed precision of the parameters to float32 in line 321 of train/train.py:

        # init MixedPrecision
        if args.precision != "fp32":
            cast_dtype = get_mp_policy_dtype(args.precision)
            mp_policy = MixedPrecision(
                param_dtype=torch.float32,
                reduce_dtype=cast_dtype,  # gradient communication
                buffer_dtype=cast_dtype,
            )

Did the training degrade when you used lower precision for the parameters? Or is there something else I am not aware of?
(I am quite new to mixed precision training)

@rphlstck rphlstck added the bug Something isn't working label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant