Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend test.join? #1285

Closed
giuseppec opened this issue Oct 13, 2016 · 0 comments
Closed

extend test.join? #1285

giuseppec opened this issue Oct 13, 2016 · 0 comments

Comments

@giuseppec
Copy link
Contributor

I observed this issue while doing #1275.

@giuseppec said:

For repeated-CV, the test.join currently computes the measure for each repeated cv separately and then averages this through the mean. For example, a 3 times repeated 10-fold CV creates cross-validated predictions for each repetition, e.g. y1, y2, and y3. In this case, currently test.join computes the measure for y1 and the real y, y2 and the real y, y3 and the real y and finally aggregates the three values using the mean. (why aggregating here? especially why using the mean?).
An alternative to this (without the issue of aggregating) would be to average the cross-validated predictions accross all reps, i.e., use the mean ymean = (y1+y2+y3)/3 and compute the measure using ymean and the real y.

@larskotthoff said:

Hmm, sounds to me like this should be configurable by the user (in particular how the aggregation is done). This is probably a separate PR though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants