Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to have an aggregate function instead of the active binding? #153

Closed
schalkdaniel opened this issue Jan 30, 2019 · 5 comments

Comments

@schalkdaniel
Copy link

Wouldn't it be nice to have a function

bmr$aggregate(params = TRUE)

which returns not just the aggregated benchmark object but also the parameter of a single learner? I have written a wrapper in tuning, but it feels a bit misplaced there.

@mllg
Copy link
Member

mllg commented Jan 30, 2019

Looking at your code is on my TODO (e.g. https://github.com/mlr-org/mlr3tuning/pull/29/files#diff-8d41897158e70fbb081fd674a26bffd0R80).

I'll get back to you tomorrow.

@mllg mllg closed this as completed in a5f2210 Feb 1, 2019
@mllg
Copy link
Member

mllg commented Feb 1, 2019

This is now a function, as requested. The interface might change again though, depending on #155.

@mllg mllg reopened this Feb 1, 2019
@mllg
Copy link
Member

mllg commented Feb 1, 2019

Actually, it might be better to provide the parameters as list column and let the user unnest them. @schalkdaniel What do you think?

@schalkdaniel
Copy link
Author

I think the data.table structure with R6 class columns is complicated enough. Unnesting the parameters manually requires to know mlr3misc and from there the unnest function. Providing some help here is ok (in my opinion).

On the other hand, tuning over a large amount of parameter (as it is for pipelines?) can bloat the aggregated data table.

So, maybe returning the parameters as list column by default, but giving the possibility to unnest them automatically?

@mllg
Copy link
Member

mllg commented Feb 21, 2019

We have a no sugar agreement. You get the list column for now. 😉

I've added an example to demonstrate how to access the params.

@mllg mllg closed this as completed Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants