Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow starter project to work with an existing server instance #6

Open
philidem opened this issue Feb 2, 2017 · 0 comments

Comments

@philidem
Copy link
Collaborator

philidem commented Feb 2, 2017

If a team already has a mature Node.js project then they're going to need to be able to utilize this project without changing the entry point or their existing development process.

I would recommend something like:

// create instance of `express`
var app = express();

// Load marko-starter into an existing configured an running express instance
require('marko-starter').server({
  // NOTE: We should discuss which properties need to go here
  type: 'express',
  config: {
    instance: app
  }
});

On a similar note we should also allow the existing code to launch the build:

// Build the project at `process.cwd()`...
require('marko-starter').build({...});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant