Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility: Don't run system commands that are specific to macOS or Linux #7

Open
philidem opened this issue Feb 2, 2017 · 2 comments
Open

Compatibility: Don't run system commands that are specific to macOS or Linux #7

philidem opened this issue Feb 2, 2017 · 2 comments

Comments

@philidem
Copy link
Collaborator

philidem commented Feb 2, 2017

In particular:

rm -rf .cache

We should rely on JavaScript implementations (such as rimraf)
@mlrawlings
Copy link
Owner

This isn't immediately obvious, but those aren't linux commands they're coming from cash which installs binaries of the same name in node_modules/.bin which gets prepended the PATH for npm scripts.

@philidem
Copy link
Collaborator Author

philidem commented Feb 2, 2017

That's not clear at all and I still think we should avoid spawning another process. rimraf is a good substitute for rm -rf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlrawlings @philidem