Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with upload to CRITs #156

Open
apolkosnik-old opened this issue Nov 23, 2015 · 2 comments
Open

Issues with upload to CRITs #156

apolkosnik-old opened this issue Nov 23, 2015 · 2 comments

Comments

@apolkosnik-old
Copy link

There are couple of issues with the code when trying to use combine with a recent version of CRITs.

  1. Source is not populated, making the indicators invisible to anybody in CRITs
  2. The old vocabulary is used to specify the IP address type
  3. Some possibly useful fields are not populated with useful data

The PR with changes for this is at: #155

The next big improvement would be to use bulk upload functionality, but I'll save that for another PR.

@alexcpsec
Copy link
Member

Hi, @frbapolkosnik ! Thanks for this issue and the PR. If I merge this #155 PR, will it solve the issues for you?

Please send an e-mail to alexcp -at- gmail -dot- com with a good e-mail for me to send you a link to our CLA. After that, I can do the merge.

Thanks.

@alexcpsec
Copy link
Member

Ah, I will merge it back to 0.1.3 now, and then backport it to our 0.2.0-dev one later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants