Fix the float truncation test.

num-traits (since 0.2.13) now returns 'inf' instead of an error
when converting from an out-of-range f64 to f32.  We now do the
out of range check on the rlua side.

Also update to num-traits 0.2.14 (current at time of writing) to
be sure we're past that change there.

Author: jugglerchris

Cargo.toml

@@ -34,7 +34,7 @@ system-lua = ["pkg-config"]
 
 [dependencies]
 libc = { version = "0.2" }
-num-traits = { version = "0.2.6" }
+num-traits = { version = "0.2.14" }
 bitflags = { version = "1.0.4" }
 bstr = {version = "0.2", features = ["std"], default_features = false }
 

src/conversion.rs

@@ -359,6 +359,17 @@ macro_rules! lua_convert_float {
                         message: Some("expected number or string coercible to number".to_string()),
                     })
                     .and_then(|n| {
+                        // We want out of range f32 to return an error instead
+                        // of inf.
+                        if std::mem::size_of::<$x>() < std::mem::size_of::<f64>() {
+                            if n.is_finite() && n.abs() > (<$x>::MAX as f64) {
+                                return Err(Error::FromLuaConversionError {
+                                    from: ty,
+                                    to: stringify!($x),
+                                    message: Some("number out of range".to_string()),
+                                });
+                            }
+                        }
                         cast(n).ok_or_else(|| Error::FromLuaConversionError {
                             from: ty,
                             to: stringify!($x),

tests/tests.rs

@@ -428,8 +428,7 @@ fn test_num_conversion() {
             lua.unpack::<f64>(lua.pack(f32::MAX).unwrap()).unwrap(),
             f32::MAX as f64
         );
-        assert!(dbg!(lua.unpack::<f32>(lua.pack(f64::MAX).unwrap())).is_err());
-        assert!(false);
+        assert!(lua.unpack::<f32>(lua.pack(f64::MAX).unwrap()).is_err());
 
         assert_eq!(
             lua.unpack::<i128>(lua.pack(1i128 << 64).unwrap()).unwrap(),