Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTR conversations get refreshed when doing a CTCP ping to someone using weechat-OTR and with whom you have a session #32

Open
koolfy opened this issue Aug 12, 2013 · 4 comments
Assignees
Milestone

Comments

@koolfy
Copy link
Collaborator

koolfy commented Aug 12, 2013

The title is pretty self-explanatory.

I think the other side doesn't understand the query and asks for a conversation refresh (because it never answers)

This is probably just about making sure once and for all ctcp queries don't interfere with ongoing OTR sessions.

@ghost ghost assigned koolfy Aug 12, 2013
@tribut
Copy link
Collaborator

tribut commented May 10, 2014

Can't reproduce. With latest master (v1.4.0-12-g01adb83) i just get

Unencrypted message received:  ping

which I think is correct unless we decide to handle \x01ping\x01 in a special way.

@mmb
Copy link
Owner

mmb commented Jan 11, 2015

@koolfy Is this still something you think we should handle?

@Mikaela
Copy link
Contributor

Mikaela commented Feb 11, 2015

Reproduced with testing #111

2015-02-11 09:24:49+0200 < nils_2> Unencrypted message received: PING 1423639489 287454
2015-02-11 09:24:56+0200 :! otr !: Private conversation has been refreshed.

WeeChat 1.2-dev and latest otr.py from /script.

@mmb
Copy link
Owner

mmb commented Feb 12, 2015

I can't reproduce the "unencrypted message received" unless the ping is the first message of the conversation and require_encryption is turned on. If there is an established OTR session ctcp goes through the encrypted channel and appears to work.

Do you know if the CTCP messages causing the problem are using NOTICE or anything other than PRIVMSG?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants