Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty impact range diff matrix throws an exception #28

Closed
mmiladi opened this issue May 6, 2020 · 3 comments · May be fixed by #29
Closed

Empty impact range diff matrix throws an exception #28

mmiladi opened this issue May 6, 2020 · 3 comments · May be fixed by #29

Comments

@mmiladi
Copy link
Owner

mmiladi commented May 6, 2020

In the procedure to get the ideal impact range in the zoomed mode, a fixed minimum probability is assigned. This causes a problem once all the probability differences are below the set threshold.

Do these the zoomed range list get empty:
https://github.com/mmiladi/MutaRNA/blob/master/bin/MutaRNA-plot.py#L129

Now the question is how to deal with this case:

  • Should the the probability threshold be dynamically lowered (e.g. by 1/10) until the list is not empty?
  • Should we report the full figure instead?

ping @martin-raden

@martin-raden
Copy link
Collaborator

dynamic decrease sounds best.

@martin-raden
Copy link
Collaborator

full figure could be backup plan...

@mmiladi mmiladi mentioned this issue May 10, 2020
@mmiladi
Copy link
Owner Author

mmiladi commented May 10, 2020

Fixed via #29

@mmiladi mmiladi closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants