Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossorigin="anonymous" to all script elements #1237

Closed
ohadschn opened this issue Sep 10, 2017 · 5 comments
Closed

Add crossorigin="anonymous" to all script elements #1237

ohadschn opened this issue Sep 10, 2017 · 5 comments

Comments

@ohadschn
Copy link
Contributor

This will allow a better debugging experience: https://stackoverflow.com/a/18336863/67824

@mmistakes
Copy link
Owner

I don't really get what problem this proposes to fix.

@ohadschn
Copy link
Contributor Author

Well if scripts were included from a different origin, it would provide a better debugging experience should something go wrong. Currently it seems like only one script is loaded and it's from the same origin (main.min.js) but I suppose that could change (I've already suggested such a change here: #1238).

@mmistakes
Copy link
Owner

Maybe I'm being dense, but I still get what benefit this adds to the average user of the theme.

@ohadschn
Copy link
Contributor Author

It just allows him to get more information should some error occur and either debug the issue himself or post a more meaningful issue here. Debuggability is important, and in this case it's pretty much free (just add an attribute).

@stale
Copy link

stale bot commented Oct 11, 2017

This issue has been automatically marked as stale because it has not had recent activity.

If this is a bug and you can still reproduce this error on the master branch, please reply with any additional information you have about it in order to keep the issue open.

If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial.

This issue will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants