-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Copy-to-Clipboard button and support bilibili video #2508
Comments
Hi, thanks for the suggestion. It seems like you've already figured out about the Bilibili video suggestion, so it'd be great if you could wrap it up and submit a pull request. We'd love to see your contribution! You can check out the documentation on contributing if you're looking for a how-to. |
OK,I will creat a pull request later. How about the copy-to-clipboard button? Is it possible to add the button in the next version? |
Depends on the solution for doing a copy and paste button for code blocks. The ones I've seen are clunky and don't let you use standard Markdown |
@mmistakes No worries. I'm 100% sure this could be done in JS-only, i.e. use JS to add buttons to every code block after page load (like it's already done for the heading anchor). |
Added bilibili support in #2512 |
See #2795 |
Summary
add a Copy-to-Clipboard button to the code block.
Make the theme support to instert bilibili video.
Motivation
add button
I think Copy-to-Clipboard button is necessary for this theme. A lot of posts contain code blocks. Now, this theme doesn't have a clip-to-clipboard button. When someone needs to copy the code, they need to select all the code and ctrl+C to copy to clipboard. It is a waste of time and inconvenience. Besides, some characters will be left. But if you add a button to the code block, it will be convenient.
I have searched for some articles to add a button by myself. I haven't learned programming before, so I can't finish it.
support post bilibili video
Can you make this theme supports insert bilibili video which is a very popular video website in China? When I instert a bilibili video in the post, it couldn't adapt to the width. This problem may not be what most people need. So I tried to solve this problem by myself. Finally I made it.
This is the code in _includes/video
The text was updated successfully, but these errors were encountered: