Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of hash function between v0.7 and v0.8 #351

Open
nponiros opened this issue Nov 7, 2021 · 1 comment
Open

Change of hash function between v0.7 and v0.8 #351

nponiros opened this issue Nov 7, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@nponiros
Copy link

nponiros commented Nov 7, 2021

The hash function for the migrations was changed in v0.8 and it now returns the name of the file instead of a hash of the file's content. Is there a reason for this change?

Looking at the code for v0.8 I would assume (didn't test it yet) that for all migrations already in the database a warning will be issued because the hash in the DB doesn't match the hash calculated for the file. Do we need to adjust all hashes already in the DB or is this a bug that should be fixed by using the old hash function?

@mmkal
Copy link
Owner

mmkal commented Nov 16, 2021

Yeah, this is a bug I'm afraid, mentioned also in #339. I will at some point push a change fixing the hashes to actually use the file content, but I may need to also add a utility for force-fixing hashes of already-run migrations. In the meantime, I'd suggest implementing your own hash function as described in the linked issue.

@mmkal mmkal added the bug Something isn't working label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants