versions of the package dependencies

[marjorieB]

The dependencies (in struct mmpkg_dep) have two fields min_version and max_version. It is said that min_version is inclusive and max_version is exclusive. However, when min_version==max_version, max_version becomes inclusive.

Therefore the function mmpkg_dep_match_version should be transformed in something like this:

static
int mmpkg_dep_match_version(const struct mmpkg_dep* dep, const struct mmpkg* pkg)
{ 
        int rv;
        mmstr const* any_version = mmstr_malloc_copy("any", strlen("any") + 1); 

        rv = (pkg != NULL
              && (mmstrequal(dep->max_version, any_version) == 0
                  || (mmstrequal(dep->min_version, dep->max_version)
                      && pkg_version_compare(pkg->version, dep->max_version) == 0)
                  || pkg_version_compare(pkg->version, dep->max_version) < 0)
              && pkg_version_compare(dep->min_version, pkg->version) <= 0); 

        mmstr_free(any_version);
        return rv; 
}

First this function is not very good, since a lot of comparison are done.
Moreover, the tests do not pass anymore with this function. I think that we should rework the tests to make the versions of the package coherent with the specifications.