Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML authentication with browser provider is failing when the SAML identity provider is AWS itself #103

Closed
NemindaPiyasena opened this issue Apr 10, 2023 · 3 comments

Comments

@NemindaPiyasena
Copy link
Contributor

NemindaPiyasena commented Apr 10, 2023

I have configured my AWS account and roles for SAML SSO, configuring the identity provider to be another AWS account. For more info on setting this up see here.

When running with saml_provider = browser, aws-runas is failing with the message illegal base64 data at input byte xxxx.

I have tackled down the issue and found that the issue is in the section where aws-runas is listening to browser events looking for the return of a SAMLResponse=xxxx.

The case is when dealing with the SAML identity provider is AWS itself. The SAML response is bit different and that's why base64 decoding is failing.

@NemindaPiyasena
Copy link
Contributor Author

Identified the issue.

The issue is that the POST request that contains the SAMLResponse=xxxx has other attributes such as RelayState=xxxx. All this data is included when trying the base64 decoding.

The decoding then fails due to the presence of & character.

So far I have #106 as a solution.

@mmmorris1975
Copy link
Owner

Fix released in 3.5.2. Let me know if it's working as expected now

@NemindaPiyasena
Copy link
Contributor Author

Thank you it is now working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants