Use snprintf

[su8]

gfalist/gfalist.c

Line 32 in 9c3fc24

sprintf(src, "v%x_%x", type, var);

can overflow u should use snprintf

[kollokollo]

Can you be more specific? What can overflow?

[su8]

gfalist/gfalist.c

Line 29 in 9c3fc24

static unsigned char vbuf[11]; /* vffff_ffff\0 */

hold élévén chars and if both héx numbérs excééd thosé élévén chars we havé ovérflow and stacksmash

[kollokollo]

Hm, Ok, so far so good, but each of the hex values can have only 4 charackters, so together this is 1+4+1+4+1=11. This should fit.

[kollokollo]

However, you are right: The new gcc version produces a lot of warnings about probably bad coding style... This could eventully be fixed. However the code works anyways, and since it is rather old, this would probably not be wirth the effort. But If you like, you could make a patch.