You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wondering about the possibility of an accessibility enhancement to set a couple basic accessibility attributes on the canvas element. Maybe even add them by default (i.e. default to accessible). Right now I'm setting these values on the qr-code component, which isn't really ideal. Thinking something like the following. I'm open to submitting a PR for this.
Default:
<!-- helloWorld = 'Hello World!"' -->
<qr-code [value]="helloWorld"></qr-code>
// Output:
// <canvas ... aria-label="Image of a custom QR code with the following content: {{ helloWorld }}" role="img">
It's hard to know how useful it is to have a default - it's probably fine for the common URL data use-case, but could imagine this being very unpleasant (with a screen reader) if the data was binary / a pairing key / etc.
Wondering about the possibility of an accessibility enhancement to set a couple basic accessibility attributes on the canvas element. Maybe even add them by default (i.e. default to accessible). Right now I'm setting these values on the qr-code component, which isn't really ideal. Thinking something like the following. I'm open to submitting a PR for this.
Default:
Overrides:
The text was updated successfully, but these errors were encountered: