Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully prune 'events_data' from codebase #1229

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Feb 22, 2024

PR Description

remove deprecated param.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87eea28) 97.61% compared to head (16d9c7a) 97.61%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1229      +/-   ##
==========================================
- Coverage   97.61%   97.61%   -0.01%     
==========================================
  Files          40       40              
  Lines        8685     8665      -20     
==========================================
- Hits         8478     8458      -20     
  Misses        207      207              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@hoechenberger hoechenberger merged commit eabe513 into mne-tools:main Feb 22, 2024
18 checks passed
@sappelhoff sappelhoff deleted the futurewarn branch February 22, 2024 12:49
@sappelhoff sappelhoff added this to the 0.15 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants