Fix probabilities returned by label_components #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscheltienne
added
the
🐞 bug
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 12 12
Lines 509 509
=======================================
Hits 490 490
Misses 19 19
Continue to review full report at Codecov.
|
added 2 commits
May 6, 2022 16:02
adam2392
reviewed
May 6, 2022
| @@ -56,7 +56,7 @@ def label_components(inst: Union[BaseRaw, BaseEpochs], ica: ICA, method: str): | |||
| labels_pred_proba = methods[method](inst, ica) | |||
| labels_pred = np.argmax(labels_pred_proba, axis=1) | |||
| labels = [ICLABEL_NUMERICAL_TO_STRING[label] for label in labels_pred] | |||
| y_pred_proba = labels_pred_proba[:, labels_pred] | |||
| y_pred_proba = labels_pred_proba[np.arange(15), labels_pred] | |||
There was a problem hiding this comment.
Doesn't this mean predictions are always predicting 15 components? Even if ICA produces e.G. 30 components?
There was a problem hiding this comment.
oh my god.. yes..
I was doing too many things at once, I'll fix it when I get home in 20 minutes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous selection would return a square matrix, e.g. if 15 components were provided, we would go from
(15, 7)shape to(15, 15)instead of(15, ).