Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Example broken on main #11100

Closed
larsoner opened this issue Aug 27, 2022 · 1 comment · Fixed by #11104
Closed

BUG: Example broken on main #11100

larsoner opened this issue Aug 27, 2022 · 1 comment · Fixed by #11104
Labels

Comments

@larsoner
Copy link
Member

@wmvanvliet I think #11080 broke tutorials/clinical/30_ecog.py:

https://app.circleci.com/pipelines/github/mne-tools/mne-python/16047/workflows/321560de-8d55-44f2-be22-e68382086eff/jobs/48440

Can you take a look?

@larsoner larsoner added the BUG label Aug 27, 2022
@wmvanvliet
Copy link
Contributor

Narrowed it down to MNE-BIDS trying to apply the montage, even though no fiducials are there yet. Before, the mri->head transform silently failed and channel positions were applied in MRI space (a situation we don't want). Then later in the example, this is fixed. I'll see if I can make MNE-BIDS be more clever about applying montages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants