-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: VTK/PyVista not freeing memory with multiple figures #8241
Comments
It's an item of #7162 |
Turns out this seems to be related to bad garbage collection. See investigations in #8266 (comment) and report in pyvista/pyvistaqt#57. It would be good if we could figure out where this is coming from. In the meantime, plotting so many montages is not going to be safe :( |
@GuillaumeFavelier interestingly enough this does not seem to happen on https://github.com/mne-tools/mne-python/blob/master/examples/visualization/plot_meg_sensors.py#L40-L47, but it does in https://github.com/mne-tools/mne-python/blob/master/examples/visualization/montage.py#L46-L60. Maybe this can help us narrow down where the problem is. On/after #8379 and sphinx-gallery/sphinx-gallery#759 we can iterate and test hopefully fairly easily using |
Never mind, it does happen on |
This is an upstream issue so I'll close at our end |
A lot of our
master
builds have failed lately, like:https://app.circleci.com/pipelines/github/mne-tools/mne-python/3597/workflows/fcb12f01-1f51-4d87-8697-5ac9e30f9411/jobs/22228
@GuillaumeFavelier I suspect it could be some recent-ish (within the last 2 months?) viz update. It was happening before the PyVista 0.26 release. Can you look to see if code from a month or two ago uses the same memory as it does now? Often it's
plot_visualize_stc.py
that breaks things, but in the example above it'splot_forward.py
.The text was updated successfully, but these errors were encountered: