Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per channel annotation is too slow #9199

Closed
mehdikuchi opened this issue Mar 26, 2021 · 4 comments
Closed

Per channel annotation is too slow #9199

mehdikuchi opened this issue Mar 26, 2021 · 4 comments
Labels

Comments

@mehdikuchi
Copy link

Per channel annotation with clear visual appearance

The Per channel annotation already developed in the dev version of the MNE, highlights the whole span of the data under view. This makes event localization visually too difficult.

What I have tried:

*I have changed the mne/viz/_figure.py code so that I could get the following annotation per channel:
image
The problem is scanning the window becomes too slow.
*

Is there anything that can be added to speed up the scanning of the data?

@mehdikuchi mehdikuchi added the ENH label Mar 26, 2021
@larsoner
Copy link
Member

Is there anything that can be added to speed up the scanning of the data?

Is it faster if you don't add the text objects? If so, we could make it so that the text just shows up on a mouseover for example

@drammock
Copy link
Member

it is on our roadmap to have per-channel annotations show up as highlighted regions (rather than text) which I think will be faster to draw. cf #8946. It's milestoned for the next release so hopefully you won't have to wait too long for it.

@mehdikuchi
Copy link
Author

Thanks for your replies.
That is good news. So I wait for the new release.

@larsoner
Copy link
Member

larsoner commented Oct 1, 2023

#8946 landed so hopefully this was fixed!

@larsoner larsoner closed this as completed Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants