-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack vertices in plot_volume_source_estimates #12025
Conversation
for more information, see https://pre-commit.ci
Looks correct to me. don't forget to change |
Glad it looks OK. I'll prune the MWE I got to make a test out of it. |
I did not find a |
Marking for merge when green, thanks in advance @mscheltienne ! |
MWE failing on main
This PR creates the variables
vertices = np.hstack(stc.vertices)
instead of relying onstc.vertices[0]
. On main,VolSourceEstimate.plot
can not plot on the left side of the brain (at least with a source space created as above) since the vertices of the left side are stored instc.vertices[1]
. With the MWE example above, it raises:With this PR, I get the plot:
Does this change makes sense to everyone, and is it the correct way to fix this indexing error (i.e. is this fix taking the correct slice)?