-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interest in filtering for RtEpochs? #10
Comments
hekolk
changed the title
Interest in filtering for RtEpochs
Interest in filtering for RtEpochs?
Aug 31, 2018
There is already epochs.filter with a phase argument for this
… |
sure I think it's a very useful and common feature
+1
|
cc @dmalt you might be interested in reviewing the code |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For online experiments, I added causal filtering to
RtEpochs
(usinglfilter
in_process_raw_buffer
), which circumvents the need for filtering on the segmented data (and needing longer epochs or risking edge artifacts).Is there interest to include this in MNE? Then I would tidy up the code and create a PR.
Current limitation of my code is that filter delay is not compensated/events are not shifted, so users should use minimal-phase or IIR filters.
The text was updated successfully, but these errors were encountered: