Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in filtering for RtEpochs? #10

Open
hekolk opened this issue Aug 31, 2018 · 4 comments
Open

Interest in filtering for RtEpochs? #10

hekolk opened this issue Aug 31, 2018 · 4 comments

Comments

@hekolk
Copy link

hekolk commented Aug 31, 2018

For online experiments, I added causal filtering to RtEpochs (using lfilter in _process_raw_buffer), which circumvents the need for filtering on the segmented data (and needing longer epochs or risking edge artifacts).

Is there interest to include this in MNE? Then I would tidy up the code and create a PR.
Current limitation of my code is that filter delay is not compensated/events are not shifted, so users should use minimal-phase or IIR filters.

@hekolk hekolk changed the title Interest in filtering for RtEpochs Interest in filtering for RtEpochs? Aug 31, 2018
@larsoner
Copy link
Member

larsoner commented Aug 31, 2018 via email

@agramfort
Copy link
Member

agramfort commented Aug 31, 2018 via email

@larsoner larsoner transferred this issue from mne-tools/mne-python Aug 21, 2019
@jasmainak
Copy link
Member

cc @dmalt you might be interested in reviewing the code

@dmalt
Copy link

dmalt commented Aug 22, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants