Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken on Windows 10 using CMake #1215

Open
programadorthi opened this issue Mar 28, 2019 · 0 comments
Open

Build broken on Windows 10 using CMake #1215

programadorthi opened this issue Mar 28, 2019 · 0 comments

Comments

@programadorthi
Copy link

return ( this->mState != 0 );

This above line I did fix changing to call: return this->mState.IsValid(); because is the same logic.

self->mGrabNextFrame = self->mFrameImage != 0;

This above line I did fix changing for the code below. I didn't know if it is correct but it works:

MOAILuaSharedPtr< int > empty;

self->mGrabNextFrame = self->mFrameImage != empty;

set (SDL2_SOURCE_DIR "${MOAI_ROOT}/3rdparty/sdl2-2.0.4")

The SDL2 third-party is using version 2.0.4 but there is 2.0.9 in submodules folder only. Changed to 2.0.9 line 5 and line 11 works.

if (( isOpenGLES == false ) && ( majorVersion < 3 )) {

This variable majorVersion is not declared in the class. I changed to sMajorVersion.

I didn't make a pull request because I don't know if these changes are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant