Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack config file. #39

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Conversation

lesykos
Copy link
Contributor

@lesykos lesykos commented Dec 12, 2016

  • Set a variables for entry & output path;
  • Custom output filename for main .js file;
  • Remove modulesDirectories (duplicate with default value);
  • devServer: remove duplicated config, add historyApiFallback;
  • Change path and name for .css file;

@moarwick moarwick merged commit 8334ea9 into elm-community:master Dec 14, 2016
moarwick added a commit that referenced this pull request Dec 14, 2016
@moarwick
Copy link
Contributor

@lesuk I just realized that after your PR, with assets getting saved into the static/ subfolder, now when we run npm run build and attempt to run the compiled project project from the /dist folder, it's broken (bad file paths). I tried a few things, and my latest version sort of works, but relies on a bunch of mv commands in the build script to move the font files.. ugly. Any chance you can pull latest and have a look? Hitting my Webpack know-how limits.. Thanks!

@lesykos
Copy link
Contributor Author

lesykos commented Jan 14, 2017

@moarwick, sadly to hear this. It's just a problem with fonts?

@moarwick
Copy link
Contributor

yes. the fonts get built into the dist/ root, but the paths are expecting them to be in dist/static/css/. i couldn't find a way to adjust webpack config to copy them to the correct location, so currently the NPM build script moves them over. feels hacky, plus the mv command does not work on Windows :( let me know if you have any ideas, otherwise I think I will revert to the old folder structure..

@lesykos
Copy link
Contributor Author

lesykos commented Jan 19, 2017

In this situation, IMO you should return to the old folder structure. I didn't think about fonts when doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants