Skip to content

Commit b99869f

Browse files
committed
DX: PHP 7.0 integration test - solve TODO for random_api_migration usage
1 parent a8feb63 commit b99869f

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/Event/Event.php

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
use Symfony\Component\EventDispatcher\EventDispatcher;
1616
use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
1717

18+
// @TODO PHP 7.1
19+
// @TODO PHP CS Fixer 3.0
1820
// Since PHP-CS-FIXER is PHP 5.6 compliant we can't always use Symfony Contracts (currently needs PHP ^7.1.3)
1921
// This conditional inheritance will be useless when PHP-CS-FIXER no longer supports PHP versions
2022
// inferior to Symfony/Contracts PHP minimal version

tests/Fixtures/Integration/misc/PHP7_0.test

+3-4
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ PHP 7.0 test.
33
--RULESET--
44
{
55
"@Symfony": true,
6-
"ordered_imports": true
6+
"ordered_imports": true,
7+
"random_api_migration": true
78
}
89
--REQUIREMENTS--
910
{"php": 70000}
@@ -61,7 +62,6 @@ class Foo implements FooInterface
6162
echo $a ?? $b;
6263

6364
// new random generator
64-
// TODO: on 2.x line add random_api_migration usage
6565
echo mt_rand(0, 1);
6666

6767
// uniform variable syntax
@@ -169,8 +169,7 @@ class Foo implements FooInterface
169169
echo $a??$b;
170170

171171
// new random generator
172-
// TODO: on 2.x line add random_api_migration usage
173-
echo mt_rand(0, 1);
172+
echo rand(0, 1);
174173

175174
// uniform variable syntax
176175
$a = array('b' => 'c');

0 commit comments

Comments
 (0)