Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputText is written wrongly #107

Closed
smsimone opened this issue Sep 1, 2022 · 12 comments
Closed

InputText is written wrongly #107

smsimone opened this issue Sep 1, 2022 · 12 comments
Labels
bug Something isn't working platform: ios Testing iOS apps is affected

Comments

@smsimone
Copy link

smsimone commented Sep 1, 2022

As stated in the screenshot below, instead of writing luigiverdi@toduba.it, the driver does not write the @ symbol but adds the quotes instead

Schermata 2022-09-01 alle 16 13 25

@dmitry-zaitsev dmitry-zaitsev added the bug Something isn't working label Sep 1, 2022
@dmitry-zaitsev
Copy link
Collaborator

I suspect this might be related to the locale set on your device. Could you try setting it to English / US to see if that solves the problem?

image

@smsimone
Copy link
Author

smsimone commented Sep 1, 2022

I tried with both English (USA) and English (UK), but it still writes the quotes instead of @

@dmitry-zaitsev
Copy link
Collaborator

What is a locale that is set on your Mac? Also, what is the language of an input method?

I am wondering if that could have an effect.

@smsimone
Copy link
Author

smsimone commented Sep 1, 2022

My Mac's locale is Italian, on the emulator I've tried English and Italian keyboard but in both cases it still writes " instead of @.

I've noticed that by running the exact same flow on an Android emulator, the virtual keyboard is shown and the drivers simulates the taps, while on iOS the virtual keyboard is not shown. Is it an intended behaviour?

@dmitry-zaitsev
Copy link
Collaborator

dmitry-zaitsev commented Sep 1, 2022

Yes, we interact with the device via Facebook's IDB that in turn talks directly to Apple frameworks.

Thanks for the context, I was able to reproduce the issue by setting my Mac OS input method to something other than English 👍

@MenilV
Copy link

MenilV commented Sep 1, 2022

without actually opening a different issue, I've noticed maestro has issues properly parsing multi-worded input on inputText. I've tried several test cases:

All of these were tested on Android with the emulator and the behavior is consistent. also went through the code but it seems as if the YAML parses defaults to null when it fails to parse the inputText String. thoughts?

edit: test cases that fail produce an empty string hence the suspicion towards the parses defaulting to null (or empty)

@Holospin
Copy link

Holospin commented Sep 2, 2022

without actually opening a different issue, I've noticed maestro has issues properly parsing multi-worded input on inputText. I've tried several test cases:

All of these were tested on Android with the emulator and the behavior is consistent. also went through the code but it seems as if the YAML parses defaults to null when it fails to parse the inputText String. thoughts?

edit: test cases that fail produce an empty string hence the suspicion towards the parses defaulting to null (or empty)

I am also running into the same problem as I was just about to create an issue. Glad to see someone already mentioned it.

@dmitry-zaitsev dmitry-zaitsev added the platform: ios Testing iOS apps is affected label Sep 2, 2022
@dmitry-zaitsev
Copy link
Collaborator

Hey folks, just wanted to call out that this is a high priority for us, we are going to look into it early next week

@dmitry-zaitsev
Copy link
Collaborator

@MenilV thanks for reporting and the test cases. The issue is different from what @smsimone mentioned, but is nonetheless valid. I have addressed it in #122 (going to be released today/tomorrow).

@smsimone I have confirmed that the issue you are facing is related to the system input method (aka keyboard language). The simplest way to fix it is to switch to a US English keyboard layout. In the meantime, I am looking for a smarter way to resolve it.

@dmitry-zaitsev
Copy link
Collaborator

dmitry-zaitsev commented Sep 5, 2022

Android part of the bug was addressed in #122 and is now available in Maestro 1.4.1

@dmitry-zaitsev
Copy link
Collaborator

Lets merge everything into #146

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.
Thank you for helping keep us our issue tracker clean!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working platform: ios Testing iOS apps is affected
Projects
None yet
Development

No branches or pull requests

4 participants