Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong error message #1948

Merged

Conversation

tokou
Copy link
Contributor

@tokou tokou commented Aug 25, 2024

Proposed changes

  • Change the error message depending on the above condition

Testing

  • ./gradlew test
  • ./maestro-cli/build/install/maestro/bin/maestro test --format=JUNIT --continuous flow.yaml

Issues fixed

Fixes #1623

Copy link
Contributor

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test seems to be failing, please fix it

Copy link
Contributor

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test if failing

@bartekpacia bartekpacia force-pushed the fix-continuous-format-error-message branch from a697633 to cbceb8a Compare August 29, 2024 22:33
@bartekpacia
Copy link
Contributor

Works fine now. Thanks a ton @tokou!

@bartekpacia bartekpacia merged commit 56d4069 into mobile-dev-inc:main Aug 30, 2024
4 checks passed
@tokou
Copy link
Contributor Author

tokou commented Aug 30, 2024

Thanks for fixing the small issue here @bartekpacia

@tokou tokou deleted the fix-continuous-format-error-message branch August 30, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong error message in cli with format+continuous flags
2 participants