-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unmaintained test dependency 'asynctest' #433
Comments
Good timing for finding this. I've replaced some of these CoroutineMocks with AsyncMock |
Currently I see: test_charge_point.py .......... [ 10%] ___________________________________________________________________________________________________ test_call_representation ___________________________________________________________________________________________________
E AssertionError: assert '<Call - uniq..., payload={}>' == '<Call - uniq..., payload={}>' test_messages.py:264: AssertionError
E assert "<CallResult ... 'Accepted'}>" == "<CallResult ... 'Accepted'}>" test_messages.py:272: AssertionError ` class Action(str, auto): I see now: ` test_charge_point.py .......... [ 10%] ====================================================================================================== 96 passed in 0.34s ====================================================================================================== test_charge_point.py .......... [ 10%] ====================================================================================================== 96 passed in 0.34s ====================================================================================================== |
Same behaviour as in #447 |
#447 and this issue are independent issues that both causes the Python 3.11 build to fail. |
What I see when running the tests is only the test failing related to Enum's issue. Once this is corrected then all the test pass. I don't see the asynctest issue shown with the pytest output above. Does it still exist? |
Interesting. I've no idea why it works now. I think it's still a good idea to remove the dependency, since it's unmaintained. And as @mgonzalezperna stated, we can replace it with a type in the stdlib, reducing the list of dependencies. |
I might then change the tag to an enhancement |
PR #585 created and approved for inclusion in v1.0.0 - so closing issue |
Running the unit test in python3.11 fails with:
It's a known issue of asynctest, see Martiusweb/asynctest#161.
The library is unmaintained and I don't expect a fix. So we should replace the library.
The text was updated successfully, but these errors were encountered: