Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Flow Typed Support #1232

Closed
halbgut opened this issue Nov 5, 2017 · 3 comments
Closed

Improve Flow Typed Support #1232

halbgut opened this issue Nov 5, 2017 · 3 comments

Comments

@halbgut
Copy link
Contributor

halbgut commented Nov 5, 2017

Flow has this .js.flow file pattern. If utilized correctly, a consumer won't have to change anything in their .flowconfig in order to get the flow typings for mobx.

We'd have to remove the wrapping module block from the .js.flow file and add export to all declared variables that are exported. I've already done this locally to test it, so I could immediately open a PR.

Projects using MobX with flow typings would have to remove the [libs] line from their config when they upgrade.
@halbgut halbgut mentioned this issue Nov 22, 2017
Merged
@mweststrate
Copy link
Member

The PR has been merged, however if I understand it correctly it does not solve the issue described above? (Properly exposing the types). Would you be interested in submitting a PR for that as well?

@halbgut
Copy link
Contributor Author

halbgut commented Nov 23, 2017

Correct. Sure thing! I'll submit a PR.

@halbgut halbgut mentioned this issue Nov 25, 2017
Merged
@mweststrate
Copy link
Member

Released as 3.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mweststrate @halbgut