Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] use ES6 map instead of array in mob.toJS() memorizer? #1519

Closed
3 tasks done
loatheb opened this issue Apr 24, 2018 · 1 comment
Closed
3 tasks done

[suggestion] use ES6 map instead of array in mob.toJS() memorizer? #1519

loatheb opened this issue Apr 24, 2018 · 1 comment

Comments

@loatheb
Copy link
Contributor

loatheb commented Apr 24, 2018

I have a Idea:

  • What problem would it solve for you?
  • Do you think others will benefit from this change as well and it should in core package (see also mobx-utils)?
  • Are you willing to (attempt) a PR yourself?

This is a suggestion of refactoring tojs method.

I looked at the code and found that in tojs comment stated that it hope to improve the performance of the cache through the ES6 Map. Also, I extract a common function in recursion.

PR is here 👉 1517

Can anyone do a review or give me some suggestion of it?

@mweststrate
Copy link
Member

Reviewed, will be part of next release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants