Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES7 interop #169

Closed
chicoxyzzy opened this issue Mar 22, 2016 · 5 comments
Closed

ES7 interop #169

chicoxyzzy opened this issue Mar 22, 2016 · 5 comments

Comments

@chicoxyzzy
Copy link
Contributor

Hi. I just want you to check out cujojs/most#160. I think that it is really useful enhancement.

@chicoxyzzy
Copy link
Contributor Author

I think I can implement this so we will be able to deprecate https://github.com/chicoxyzzy/rx-mobx :)

@mweststrate
Copy link
Member

Fancy! Feel free to take a shot at it :)

@chicoxyzzy
Copy link
Contributor Author

chicoxyzzy commented May 1, 2016

Wow actually this is way more complicated than I thought =) I am familiar with TypeScript though I need to explore mobx source code a bit to find a place where to add Symbol.observable method and realize how to do it proper

@mweststrate
Copy link
Member

I think you need to add it to the prototypes of ObservableValue, ComputedValue, ObservableArray, ObservableMap and as symbol when extend an object. In all 5 cases you can probably use some identical utility function that wraps around mobx.observe.

@benjamingr
Copy link
Member

I think we can close this now given #677 and blesh's intent to implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants