Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile heredoc progress bars #2167

Closed
jedevc opened this issue Jun 12, 2021 · 1 comment · Fixed by #2201
Closed

Dockerfile heredoc progress bars #2167

jedevc opened this issue Jun 12, 2021 · 1 comment · Fixed by #2201
Assignees

Comments

@jedevc
Copy link
Member

jedevc commented Jun 12, 2021

Hello again 🎉

This is a tracking issue for following up on this comment by @tonistiigi:

For the follow-ups I think there are some cases that need to be tested/added for the heredoc parsing with shell rules. I think there are some unhandled cases atm. Another thing to look at is what message to have in the progressbar so it gives the best indication for the user.

Essentially, buildkit should produce "useful" messages for heredoc commands.

There are probably a few aspects of this:

  • File creation in a scratch container (need a message to indicate what files are being created, this currently doesn't exist at all)
  • File copying in ADD/COPY (need a message to indicate the destination of the file, this kind of currently works)
  • Running heredoc contents in RUN (need a message to indicate what is being run, and it would be very nice to give some indication as to how - since there's a couple ways that heredocs are created and run).

I'll hopefully have some time to take a look at this (and any other follow-up issues that end up being made) at some point this week 👍

@tonistiigi
Copy link
Member

File creation in a scratch container

This can be [internal] preparing here-document

File copying in ADD/COPY

Yes, this mostly is ok already. Could consider normalized <<here-doc or smth like (inline) but not sure if improves.

Running heredoc contents in RUN

This is the trickiest. If there is a (long) command then I think we can just show it as is. But if it is just a script/shebang then I think we should try to find some words from its contents. python script: print("hello")... ?? Not quite sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants