Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML reporter retains old 'grep=' querystrings when changing suites #1494

Closed
callmevlad opened this issue Jan 7, 2015 · 2 comments · Fixed by #1495
Closed

HTML reporter retains old 'grep=' querystrings when changing suites #1494

callmevlad opened this issue Jan 7, 2015 · 2 comments · Fixed by #1495

Comments

@callmevlad
Copy link
Contributor

Currently, if you use the http://localhost/tests.html?grep=MySuite format for limiting Mocha tests in the browser, all the suite/test links in the report get additional grep= params. Clicking on them retains older (ignored) values in the URL:

http://localhost/tests.html?grep=MySuite&grep=MySuite%20%23someMethod

Switching back to the higher suite will tack on yet another param:

http://localhost/tests.html?grep=MySuite&grep=MySuite%20%23someMethod&grep=MySuite

Ideally, switching to a new grep setting should clear the existing one in the URL. I'll submit a PR which implements this desired behavior.

@kristoferjoseph
Copy link

👍

@travisjeffery
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants