Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump major version of glob #2247

Closed
eljefedelrodeodeljefe opened this issue May 11, 2016 · 12 comments
Closed

Bump major version of glob #2247

eljefedelrodeodeljefe opened this issue May 11, 2016 · 12 comments

Comments

@eljefedelrodeodeljefe
Copy link

Can you please bump the version of glob? I think this repo is the reason why I see deprecations warnings for graceful-fs on nearly every npm install

@eljefedelrodeodeljefe
Copy link
Author

See

yargs@4.7.0 /Users/jefe/repos/yargs
├─┬ cpr@1.1.1
│ └── graceful-fs@4.1.4 
├─┬ mocha@2.4.5
│ └─┬ glob@3.2.3
│   └── graceful-fs@2.0.3 
└─┬ nyc@6.4.4
  ├─┬ caching-transform@1.0.1
  │ └─┬ write-file-atomic@1.1.4
  │   └── graceful-fs@4.1.4 
  └─┬ yargs@4.7.0
    ├─┬ pkg-conf@1.1.2
    │ └─┬ load-json-file@1.1.0
    │   └── graceful-fs@4.1.4 
    └─┬ read-pkg-up@1.0.1
      └─┬ read-pkg@1.1.0
        ├─┬ load-json-file@1.1.0
        │ └── graceful-fs@4.1.4 
        └─┬ path-type@1.1.0
          └── graceful-fs@4.1.4 

@robogeek
Copy link

npm WARN deprecated graceful-fs@2.0.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.

@wyaeld
Copy link

wyaeld commented May 14, 2016

I can see this is done by c9bcfc1

but still need them to actually cut a release

@eljefedelrodeodeljefe
Copy link
Author

That and still it's only v3. @boneskull I feel this is rather urgent. Can you cut a release from this?

@boneskull
Copy link
Contributor

@eljefedelrodeodeljefe What's urgent about it?

@boneskull
Copy link
Contributor

(a release won't happen until #2231 is merged; this will likely happen before Node.js v7 is released. if you're in a hurry, you can either suppress the warnings or npm install mochajs/mocha to get the latest source in master)

@eljefedelrodeodeljefe
Copy link
Author

It's very bad UX for two thirds of npm users seeing deprecations warnings and wondering what is wrong and not being able to do anything.

@eljefedelrodeodeljefe
Copy link
Author

hmm. Waiting for that PR seems ambitious.

@boneskull
Copy link
Contributor

boneskull commented May 14, 2016

channeling Allen Iverson

I mean, listen, we're sitting here talking about a warning. Not an error. Not an error. Not an error. But we're talking about a warning. We're not talking about an error. We're not actually talking about an error, where it actually matters, but we're talking about a warning.


I've seen maybe 10 issues created for this warning. I am not sure what is so scary about a warning involving a version of Node.js that is not released yet. Let's just all take a deep breath and realize that the sky will not fall.

We'll do the next release methodically to mitigate the likelihood of actual errors. We're not going to rush it to suppress a warning.

@eljefedelrodeodeljefe
Copy link
Author

Yeah that's all fine. Still that makes me question why an integral part of the ecosystem fails to nurture its development by not updating ancient dependencies. The is the pre-stage of issues like left-pad and deeply worry me.

@boneskull
Copy link
Contributor

@wyaeld
Copy link

wyaeld commented May 23, 2016

It's pretty obvious at this point that @boneskull

  1. has a plan on when he wants to release
  2. cares about maintaining compatibility for his users

He's described a workaround, I just updated to use it and moved on.

Here are the docs for anyone not familiar with that - ironically using mocha as an example.
https://docs.npmjs.com/files/package.json#github-urls

Comparing this to left-pad is a bit poor though. The team here deserves a bit of gratitude for the work being put in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants