Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manually activated failure tests with throw assertions #2309

Closed
ScottFreeCode opened this issue Jun 13, 2016 · 0 comments
Closed

Replace manually activated failure tests with throw assertions #2309

ScottFreeCode opened this issue Jun 13, 2016 · 0 comments
Labels
type: chore generally involving deps, tooling, configuration, etc.

Comments

@ScottFreeCode
Copy link
Contributor

ScottFreeCode commented Jun 13, 2016

Go through the test suites and find things that are failure-tests but either commented out or otherwise unusually handled and if possible change them to assert that the failure throws or passes an error to a callback or whatever the expectable failure mode is.

For example:

// uncomment
// fs.readFile(tmpFile('does-not-exist'), done);

@boneskull boneskull added the type: chore generally involving deps, tooling, configuration, etc. label Jun 27, 2016
@juergba juergba closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Development

No branches or pull requests

3 participants