Dont count xunit failures as errors #2475

mlucool · 2016-09-12T21:09:23Z

Per http://reflex.gforge.inria.fr/xunit.html#xunitReport a failure and an error are different concepts and must be counted as such. Some parsers will fail if the number of expected tests do not add up.

Per http://reflex.gforge.inria.fr/xunit.html#xunitReport a failure and an error are different concepts and must be counted as such. Some parsers will fail if the number of expected tests do not add up. Related change in repo from which this was copied: mochajs/mocha#2475

boneskull · 2016-09-17T00:40:25Z

@mlucool Thanks. What's an "error"? Shouldn't we report the number of them instead of 0?

boneskull · 2016-09-17T00:41:21Z

This is a bug if the output is incorrect, but I don't know enough about XUnit to say whether or not this is true.

mlucool · 2016-09-17T12:33:32Z

@boneskull the documentation says:

@errors indicates the number of assertions that weren't true.
@failures indicates the number of test cases that fail to run. A single report should report 1 or 0, but if several reports are merged, a greater number could be reported.

Then in the xunit.xml file on the <test-suite> level:

@errors : the number of test cases that report at least one error
@failures : the number of test cases that report at least one failure

Reporting failures as errors it is clearly the wrong thing to do, but from a reread, we might be that we want to flip errors and failures in this commit (such that failures is always 0 while errors is the number of tests with issues). As far as I can tell, this does not gracefully handle the error case and when something can't run, it exits so no xunit.xml would be created.

boneskull · 2016-09-18T21:57:23Z

OK. To summarize, it seems that we need to report errors and not failures as a first pass. Otherwise, if a "before" or "beforeEach" hook fails, and thus causes tests to not run, we should count those as failures. But that needn't be part of this PR. Can you please make the necessary change? Thanks!

mlucool · 2016-09-19T02:36:05Z

Updated - please squash and merge unless you have another change

mlucool · 2016-10-01T14:45:01Z

@boneskull can we merge this?

mlucool · 2017-02-28T19:50:55Z

Reminder: @boneskull

mlucool · 2017-03-10T23:25:58Z

@craigtaub @Munter Any thoughts?

mlucool · 2017-07-12T18:20:26Z

Reminder: @boneskull @ScottFreeCode @Munter

boneskull · 2018-04-07T22:56:52Z

sign CLA if still interested.

mlucool · 2018-04-08T00:22:39Z

@boneskull signed

boneskull

Thanks. That's weird; why wouldn't a test case run?

Can you please add a test to test/reporters/xunit.spec.js? I'm not sure if this file even existed when the PR was originally created. You should be able to assert that failures is always 0 and any test failure (assertion error) ends up in errors (inspect <testsuite>).

craigtaub · 2018-12-02T11:53:46Z

@mlucool have you had any time to look at this?

mlucool · 2018-12-04T22:38:28Z

@boneskull fixed the conflicts

craigtaub · 2018-12-11T15:51:32Z

test/reporters/xunit.spec.js

@@ -320,6 +321,57 @@ describe('XUnit reporter', function() {
        expect(expectedWrite, 'to be', expectedTag);
      });
    });
+    describe('should write expected summary statistics', function() {


This needs to be it(.

Also considering the change, feels like this should be in the "on test failure" block and have a more specific spec (i.e. failed assertion is reported as an error not a failure).

Fixed the describe vs. it - thanks!

Although these changes test for that issue, the unit test should be there to ensure that all xunit outlook looks correct.

boneskull · 2018-12-18T01:19:00Z

LGTM. Probably better to use Sinon to mock stuff, but we can change that later.

boneskull · 2018-12-18T01:19:13Z

thanks!

## The devDependency [mocha](https://github.com/mochajs/mocha) was updated from `5.2.0` to `6.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v6.0.0</summary> <h1>6.0.0 / 2019-02-18</h1> <h2><g-emoji class="g-emoji" alias="boom" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f4a5.png">💥</g-emoji> Breaking Changes</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3149" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3149/hovercard">#3149</a>: Drop Node.js v4.x support (<a href="https://urls.greenkeeper.io/outsideris">@outsideris</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3556" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3556/hovercard">#3556</a>: Changes to command-line options (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>): <ul> <li><code>--grep</code> and <code>--fgrep</code> are now mutually exclusive; attempting to use both will cause Mocha to fail instead of simply ignoring <code>--grep</code></li> <li><code>--compilers</code> is no longer supported; attempting to use will cause Mocha to fail with a link to more information</li> <li><code>-d</code> is no longer an alias for <code>--debug</code>; <code>-d</code> is currently ignored</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3275" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3275/hovercard">#3275</a>: <code>--watch-extensions</code> no longer implies <code>js</code>; it must be explicitly added (<a href="https://urls.greenkeeper.io/TheDancingCode">@TheDancingCode</a>)</li> </ul> </li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2908" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/2908/hovercard">#2908</a>: <code>tap</code> reporter emits error messages (<a href="https://urls.greenkeeper.io/chrmod">@chrmod</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2819" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2819/hovercard">#2819</a>: When conditionally skipping in a <code>before</code> hook, subsequent <code>before</code> hooks and tests in nested suites are now skipped (<a href="https://urls.greenkeeper.io/bannmoore">@bannmoore</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/627" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/627/hovercard">#627</a>: Emit filepath in "timeout exceeded" exceptions where applicable (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3556" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3556/hovercard">#3556</a>: <code>lib/template.html</code> has moved to <code>lib/browser/template.html</code> (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2576" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2576/hovercard">#2576</a>: An exception is now thrown if Mocha fails to parse or find a <code>mocha.opts</code> at a user-specified path (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3458" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3458/hovercard">#3458</a>: Instantiating a <code>Base</code>-extending reporter without a <code>Runner</code> parameter will throw an exception (<a href="https://urls.greenkeeper.io/craigtaub">@craigtaub</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3125" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3125/hovercard">#3125</a>: For consumers of Mocha's programmatic API, all exceptions thrown from Mocha now have a <code>code</code> property (and some will have additional metadata). Some <code>Error</code> messages have changed. Please use the <code>code</code> property to check <code>Error</code> types instead of the <code>message</code> property; these descriptions will be localized in the future. (<a href="https://urls.greenkeeper.io/craigtaub">@craigtaub</a>)</li> </ul> <h2><g-emoji class="g-emoji" alias="fax" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f4e0.png">📠</g-emoji> Deprecations</h2> These are soft-deprecated, and will emit a warning upon use. Support will be removed in (likely) the next major version of Mocha: <ul> <li><code>-gc</code> users should use <code>--gc-global</code> instead</li> <li>Consumers of the function exported by <code>bin/options</code> should now use the <code>loadMochaOpts</code> or <code>loadOptions</code> (preferred) functions exported by the <code>lib/cli/options</code> module</li> </ul> Regarding the <code>Mocha</code> class constructor (from <code>lib/mocha</code>): <ul> <li>Use property <code>color: false</code> instead of <code>useColors: false</code></li> <li>Use property <code>timeout: false</code> instead of <code>enableTimeouts: false</code></li> </ul> All of the above deprecations were introduced by <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3556" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3556/hovercard">#3556</a>. <code>mocha.opts</code> is now considered "legacy"; please prefer RC file or <code>package.json</code> over <code>mocha.opts</code>. <h2><g-emoji class="g-emoji" alias="tada" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f389.png">🎉</g-emoji> Enhancements</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3726" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3726/hovercard">#3726</a>: Add ability to unload files from <code>require</code> cache (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> </ul> Enhancements introduced in <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3556" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3556/hovercard">#3556</a>: <ul> <li> Mocha now supports "RC" files in JS, JSON, YAML, or <code>package.json</code>-based (using <code>mocha</code> property) format <ul> <li><code>.mocharc.js</code>, <code>.mocharc.json</code>, <code>.mocharc.yaml</code> or <code>.mocharc.yml</code> are valid "rc" file names and will be automatically loaded</li> <li>Use <code>--config /path/to/rc/file</code> to specify an explicit path</li> <li>Use <code>--package /path/to/package.json</code> to specify an explicit <code>package.json</code> to read the <code>mocha</code> prop from</li> <li>Use <code>--no-config</code> or <code>--no-package</code> to completely disable loading of configuration via RC file and <code>package.json</code>, respectively</li> <li>Configurations are merged as applicable using the priority list: <ol> <li>Command-line arguments</li> <li>RC file</li> <li><code>package.json</code></li> <li><code>mocha.opts</code></li> <li>Mocha's own defaults</li> </ol> </li> <li>Check out these <a href="https://urls.greenkeeper.io/mochajs/mocha/tree/master/example/config">example config files</a></li> </ul> </li> <li> Node/V8 flag support in <code>mocha</code> executable: <ul> <li>Support all allowed <code>node</code> flags as supported by the running version of <code>node</code> (also thanks to <a href="https://urls.greenkeeper.io/demurgos">@demurgos</a>)</li> <li>Support any V8 flag by prepending <code>--v8-</code> to the flag name</li> <li>All flags are also supported via config files, <code>package.json</code> properties, or <code>mocha.opts</code></li> <li>Debug-related flags (e.g., <code>--inspect</code>) now imply <code>--no-timeouts</code></li> <li>Use of e.g., <code>--debug</code> will automatically invoke <code>--inspect</code> if supported by running version of <code>node</code></li> </ul> </li> <li> Support negation of any Mocha-specific command-line flag by prepending <code>--no-</code> to the flag name </li> <li> Interfaces now have descriptions when listed using <code>--interfaces</code> flag </li> <li> <code>Mocha</code> constructor supports all options </li> <li> <code>--extension</code> is now an alias for <code>--watch-extensions</code> and affects non-watch-mode test runs as well. For example, to run only <code>test/*.coffee</code> (not <code>test/*.js</code>), you can do <code>mocha --require coffee-script/register --extensions coffee</code>. </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3552" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3552/hovercard">#3552</a>: <code>tap</code> reporter is now TAP13-capable (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a> & <a href="https://urls.greenkeeper.io/mollstam">@mollstam</a>) </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3535" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3535/hovercard">#3535</a>: Mocha's version can now be queried programmatically via public property <code>Mocha.prototype.version</code> (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>) </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3428" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3428/hovercard">#3428</a>: <code>xunit</code> reporter shows diffs (<a href="https://urls.greenkeeper.io/mlucool">@mlucool</a>) </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2529" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2529/hovercard">#2529</a>: <code>Runner</code> now emits a <code>retry</code> event when tests are retried (reporters can listen for this) (<a href="https://urls.greenkeeper.io/catdad">@catdad</a>) </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2962" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/2962/hovercard">#2962</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3111" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3111/hovercard">#3111</a>: In-browser notification support; warn about missing prereqs when <code>--growl</code> supplied (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>) </li> </ul> <h2><g-emoji class="g-emoji" alias="bug" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f41b.png">🐛</g-emoji> Fixes</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3737" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3737/hovercard">#3737</a>: Fix falsy values from options globals (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3707" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3707/hovercard">#3707</a>: Fix encapsulation issues for <code>Suite#_onlyTests</code> and <code>Suite#_onlySuites</code> (<a href="https://urls.greenkeeper.io/vkarpov15">@vkarpov15</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3711" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3711/hovercard">#3711</a>: Fix diagnostic messages dealing with plurality and markup of output (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3723" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3723/hovercard">#3723</a>: Fix "reporter-option" to allow comma-separated options (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3722" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3722/hovercard">#3722</a>: Fix code quality and performance of <code>lookupFiles</code> and <code>files</code> (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3650" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3650/hovercard">#3650</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3654" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3654/hovercard">#3654</a>: Fix noisy error message when no files found (<a href="https://urls.greenkeeper.io/craigtaub">@craigtaub</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3632" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3632/hovercard">#3632</a>: Tests having an empty title are no longer confused with the "root" suite (<a href="https://urls.greenkeeper.io/juergba">@juergba</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3666" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3666/hovercard">#3666</a>: Fix missing error codes (<a href="https://urls.greenkeeper.io/vkarpov15">@vkarpov15</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3684" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3684/hovercard">#3684</a>: Fix exiting problem in Node.js v11.7.0+ (<a href="https://urls.greenkeeper.io/addaleax">@addaleax</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3691" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3691/hovercard">#3691</a>: Fix <code>--delay</code> (and other boolean options) not working in all cases (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3692" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3692/hovercard">#3692</a>: Fix invalid command-line argument usage not causing actual errors (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3698" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3698/hovercard">#3698</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3699" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3699/hovercard">#3699</a>: Fix debug-related Node.js options not working in all cases (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3700" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3700/hovercard">#3700</a>: Growl notifications now show the correct number of tests run (<a href="https://urls.greenkeeper.io/outsideris">@outsideris</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3686" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3686/hovercard">#3686</a>: Avoid potential ReDoS when diffing large objects (<a href="https://urls.greenkeeper.io/cyjake">@cyjake</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3715" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3715/hovercard">#3715</a>: Fix incorrect order of emitted events when used programmatically (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3706" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3706/hovercard">#3706</a>: Fix regression wherein <code>--reporter-option</code>/<code>--reporter-options</code> did not support comma-separated key/value pairs (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li>Fix missing <code>mocharc.json</code> in published package (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3356" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3356/hovercard">#3356</a>: <code>--no-timeouts</code> and <code>--timeout 0</code> now does what you'd expect (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3475" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3475/hovercard">#3475</a>: Restore <code>--no-exit</code> option (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3570" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3570/hovercard">#3570</a>: Long-running tests now respect <code>SIGINT</code> (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2944" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2944/hovercard">#2944</a>: <code>--forbid-only</code> and <code>--forbid-pending</code> now "fail fast" when encountered on a suite (<a href="https://urls.greenkeeper.io/outsideris">@outsideris</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/1652" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/1652/hovercard">#1652</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2951" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2951/hovercard">#2951</a>: Fix broken clamping of timeout values (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2753" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2753/hovercard">#2753</a>: <code>start</code> and <code>end</code> events now emitted properly from <code>Runner</code> instance when using Mocha programmatically (<a href="https://urls.greenkeeper.io/outsideris">@outsideris</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2095" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2095/hovercard">#2095</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3521" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3521/hovercard">#3521</a>: Do not log <code>stdout:</code> prefix in browser console (<a href="https://urls.greenkeeper.io/Bamieh">@Bamieh</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3595" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3595/hovercard">#3595</a>: Fix mochajs.org deployment problems (<a href="https://urls.greenkeeper.io/papandreou">@papandreou</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3518" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3518/hovercard">#3518</a>: Improve <code>utils.isPromise()</code> (<a href="https://urls.greenkeeper.io/fabiosantoscode">@fabiosantoscode</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3320" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3320/hovercard">#3320</a>: Fail gracefully when non-extensible objects are thrown in async tests (<a href="https://urls.greenkeeper.io/fargies">@fargies</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2475" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/2475/hovercard">#2475</a>: XUnit does not duplicate test result numbers in "errors" and "failures"; "failures" will always be zero (<a href="https://urls.greenkeeper.io/mlucool">@mlucool</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3398" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3398/hovercard">#3398</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3598" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3598/hovercard">#3598</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3457" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3457/hovercard">#3457</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3617" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3617/hovercard">#3617</a>: Fix regression wherein <code>--bail</code> would not execute "after" nor "after each" hooks (<a href="https://urls.greenkeeper.io/juergba">@juergba</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3580" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3580/hovercard">#3580</a>: Fix potential exception when using XUnit reporter programmatically (<a href="https://urls.greenkeeper.io/Lana-Light">@Lana-Light</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/1304" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/1304/hovercard">#1304</a>: Do not output color to <code>TERM=dumb</code> (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> </ul> <h2><g-emoji class="g-emoji" alias="book" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f4d6.png">📖</g-emoji> Documentation</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3525" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3525/hovercard">#3525</a>: Improvements to <code>.github/CONTRIBUTING.md</code> (<a href="https://urls.greenkeeper.io/markowsiak">@markowsiak</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3466" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3466/hovercard">#3466</a>: Update description of <code>slow</code> option (<a href="https://urls.greenkeeper.io/finfin">@finfin</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3405" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3405/hovercard">#3405</a>: Remove references to bower installations (<a href="https://urls.greenkeeper.io/goteamtim">@goteamtim</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3361" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3361/hovercard">#3361</a>: Improvements to <code>--watch</code> docs (<a href="https://urls.greenkeeper.io/benglass">@benglass</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3136" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3136/hovercard">#3136</a>: Improve docs around globbing and shell expansion (<a href="https://urls.greenkeeper.io/akrawchyk">@akrawchyk</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2819" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2819/hovercard">#2819</a>: Update docs around skips and hooks (<a href="https://urls.greenkeeper.io/bannmoore">@bannmoore</a>)</li> <li>Many improvements by <a href="https://urls.greenkeeper.io/outsideris">@outsideris</a></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3652" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3652/hovercard">#3652</a>: Switch from Jekyll to Eleventy (<a href="https://urls.greenkeeper.io/Munter">@Munter</a>)</li> </ul> <h2><g-emoji class="g-emoji" alias="nut_and_bolt" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f529.png">🔩</g-emoji> Other</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3677" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3677/hovercard">#3677</a>: Add error objects for createUnsupportedError and createInvalidExceptionError (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3733" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3733/hovercard">#3733</a>: Removed unnecessary processing in post-processing hook (<a href="https://urls.greenkeeper.io/wanseob">@wanseob</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3730" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3730/hovercard">#3730</a>: Update nyc to latest version (<a href="https://urls.greenkeeper.io/coreyfarrell">@coreyfarrell</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3648" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3648/hovercard">#3648</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3680" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3680/hovercard">#3680</a>: Fixes to support latest versions of <a href="https://npm.im/unexpected" rel="nofollow">unexpected</a> and <a href="https://npm.im/unexpected-sinon" rel="nofollow">unexpected-sinon</a> (<a href="https://urls.greenkeeper.io/sunesimonsen">@sunesimonsen</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3638" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3638/hovercard">#3638</a>: Add meta tag to site (<a href="https://urls.greenkeeper.io/MartijnCuppens">@MartijnCuppens</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3653" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3653/hovercard">#3653</a>: Fix parts of test suite failing to run on Windows (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3557" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3557/hovercard">#3557</a>: Use <code>ms</code> userland module instead of hand-rolled solution (<a href="https://urls.greenkeeper.io/gizemkeser">@gizemkeser</a>)</li> <li>Many CI fixes and other refactors by <a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a></li> <li>Test refactors by <a href="https://urls.greenkeeper.io/outsideris">@outsideris</a></li> </ul> </details> <details> <summary>Commits</summary> The new version differs by 209 commits ahead by 209, behind by 39. <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/42303e2acba217af554294b1174ee53b5627cc33"><code>42303e2</code></a> <code>Release v6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/a553ca70287f407abd4a82180e4a1155b8730756"><code>a553ca7</code></a> <code>punctuation updates for changelog v6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/c7107926b3a546960e841b0339bf4a3b85170c4c"><code>c710792</code></a> <code>grammar updates for changelog v6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/9f9293a0db44ce41e1bd9cc38d68e3d7a1010f41"><code>9f9293a</code></a> <code>update changelog for v6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/a540eb06f23135db563a6b2bd2e0b3b51583fde7"><code>a540eb0</code></a> <code>remove "projects" section from MAINTAINERS.md [ci skip]</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/52b5c42c3dda8c386735969642843bd1129a4562"><code>52b5c42</code></a> <code>Uppercased JSON reporter name in <code>describe</code> title (#3739)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/82307fbf9bfa7cd72042facd1d42fb108257100c"><code>82307fb</code></a> <code>Fix <code>.globals</code> to remove falsy values (#3737)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/56dc28e62f63903632d5fe4169b52cb2cdb5f7ea"><code>56dc28e</code></a> <code>Remove unnecessary post-processing code having no effect; closes #3708 (#3733)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/16b4281b6e86d93e959a37f830a349c0542d968a"><code>16b4281</code></a> <code>Documentation updates (#3728)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/5d9d3eb665825ea69435388f5776150f40c844be"><code>5d9d3eb</code></a> <code>Update nyc</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/118c9aeab5b6192d627b0b369e43584ab8f9f0b7"><code>118c9ae</code></a> <code>Refactor out usages of Suite#_onlyTests and Suite#_onlyTests (#3689) (#3707)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/0dacd1fb0067e40f8567653f828f677022e4fb89"><code>0dacd1f</code></a> <code>Add ability to unload files from <code>require</code> cache (redux) (#3726)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/66a52f25cafd266ab3cce2db975a560a695ecae9"><code>66a52f2</code></a> <code>update release steps [ci skip]</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/45ae014d0baba97b4b50b37ae526e1b50a9334e9"><code>45ae014</code></a> <code>Refactor <code>lookupFiles</code> and <code>files</code> (#3722)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/94c932095b4b8e8a7a5d9dde93ad2172d95f5ebe"><code>94c9320</code></a> <code>fix --reporter-option to allow comma-separated options; closes #3706</code></li> </ul> There are 209 commits in total. See the <a href="https://urls.greenkeeper.io/mochajs/mocha/compare/5bd33a0ba201d227159759e8ced86756595b0c54...42303e2acba217af554294b1174ee53b5627cc33">full diff</a> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: null <greenkeeper[bot]@users.noreply.github.com>

## The devDependency [mocha](https://github.com/mochajs/mocha) was updated from `5.2.0` to `6.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v6.0.0</summary> <h1>6.0.0 / 2019-02-18</h1> <h2><g-emoji class="g-emoji" alias="boom" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f4a5.png">💥</g-emoji> Breaking Changes</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3149" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3149/hovercard">#3149</a>: Drop Node.js v4.x support (<a href="https://urls.greenkeeper.io/outsideris">@outsideris</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3556" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3556/hovercard">#3556</a>: Changes to command-line options (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>): <ul> <li><code>--grep</code> and <code>--fgrep</code> are now mutually exclusive; attempting to use both will cause Mocha to fail instead of simply ignoring <code>--grep</code></li> <li><code>--compilers</code> is no longer supported; attempting to use will cause Mocha to fail with a link to more information</li> <li><code>-d</code> is no longer an alias for <code>--debug</code>; <code>-d</code> is currently ignored</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3275" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3275/hovercard">#3275</a>: <code>--watch-extensions</code> no longer implies <code>js</code>; it must be explicitly added (<a href="https://urls.greenkeeper.io/TheDancingCode">@TheDancingCode</a>)</li> </ul> </li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2908" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/2908/hovercard">#2908</a>: <code>tap</code> reporter emits error messages (<a href="https://urls.greenkeeper.io/chrmod">@chrmod</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2819" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2819/hovercard">#2819</a>: When conditionally skipping in a <code>before</code> hook, subsequent <code>before</code> hooks and tests in nested suites are now skipped (<a href="https://urls.greenkeeper.io/bannmoore">@bannmoore</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/627" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/627/hovercard">#627</a>: Emit filepath in "timeout exceeded" exceptions where applicable (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3556" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3556/hovercard">#3556</a>: <code>lib/template.html</code> has moved to <code>lib/browser/template.html</code> (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2576" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2576/hovercard">#2576</a>: An exception is now thrown if Mocha fails to parse or find a <code>mocha.opts</code> at a user-specified path (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3458" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3458/hovercard">#3458</a>: Instantiating a <code>Base</code>-extending reporter without a <code>Runner</code> parameter will throw an exception (<a href="https://urls.greenkeeper.io/craigtaub">@craigtaub</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3125" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3125/hovercard">#3125</a>: For consumers of Mocha's programmatic API, all exceptions thrown from Mocha now have a <code>code</code> property (and some will have additional metadata). Some <code>Error</code> messages have changed. Please use the <code>code</code> property to check <code>Error</code> types instead of the <code>message</code> property; these descriptions will be localized in the future. (<a href="https://urls.greenkeeper.io/craigtaub">@craigtaub</a>)</li> </ul> <h2><g-emoji class="g-emoji" alias="fax" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f4e0.png">📠</g-emoji> Deprecations</h2> These are soft-deprecated, and will emit a warning upon use. Support will be removed in (likely) the next major version of Mocha: <ul> <li><code>-gc</code> users should use <code>--gc-global</code> instead</li> <li>Consumers of the function exported by <code>bin/options</code> should now use the <code>loadMochaOpts</code> or <code>loadOptions</code> (preferred) functions exported by the <code>lib/cli/options</code> module</li> </ul> Regarding the <code>Mocha</code> class constructor (from <code>lib/mocha</code>): <ul> <li>Use property <code>color: false</code> instead of <code>useColors: false</code></li> <li>Use property <code>timeout: false</code> instead of <code>enableTimeouts: false</code></li> </ul> All of the above deprecations were introduced by <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3556" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3556/hovercard">#3556</a>. <code>mocha.opts</code> is now considered "legacy"; please prefer RC file or <code>package.json</code> over <code>mocha.opts</code>. <h2><g-emoji class="g-emoji" alias="tada" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f389.png">🎉</g-emoji> Enhancements</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3726" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3726/hovercard">#3726</a>: Add ability to unload files from <code>require</code> cache (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> </ul> Enhancements introduced in <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3556" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3556/hovercard">#3556</a>: <ul> <li> Mocha now supports "RC" files in JS, JSON, YAML, or <code>package.json</code>-based (using <code>mocha</code> property) format <ul> <li><code>.mocharc.js</code>, <code>.mocharc.json</code>, <code>.mocharc.yaml</code> or <code>.mocharc.yml</code> are valid "rc" file names and will be automatically loaded</li> <li>Use <code>--config /path/to/rc/file</code> to specify an explicit path</li> <li>Use <code>--package /path/to/package.json</code> to specify an explicit <code>package.json</code> to read the <code>mocha</code> prop from</li> <li>Use <code>--no-config</code> or <code>--no-package</code> to completely disable loading of configuration via RC file and <code>package.json</code>, respectively</li> <li>Configurations are merged as applicable using the priority list: <ol> <li>Command-line arguments</li> <li>RC file</li> <li><code>package.json</code></li> <li><code>mocha.opts</code></li> <li>Mocha's own defaults</li> </ol> </li> <li>Check out these <a href="https://urls.greenkeeper.io/mochajs/mocha/tree/master/example/config">example config files</a></li> </ul> </li> <li> Node/V8 flag support in <code>mocha</code> executable: <ul> <li>Support all allowed <code>node</code> flags as supported by the running version of <code>node</code> (also thanks to <a href="https://urls.greenkeeper.io/demurgos">@demurgos</a>)</li> <li>Support any V8 flag by prepending <code>--v8-</code> to the flag name</li> <li>All flags are also supported via config files, <code>package.json</code> properties, or <code>mocha.opts</code></li> <li>Debug-related flags (e.g., <code>--inspect</code>) now imply <code>--no-timeouts</code></li> <li>Use of e.g., <code>--debug</code> will automatically invoke <code>--inspect</code> if supported by running version of <code>node</code></li> </ul> </li> <li> Support negation of any Mocha-specific command-line flag by prepending <code>--no-</code> to the flag name </li> <li> Interfaces now have descriptions when listed using <code>--interfaces</code> flag </li> <li> <code>Mocha</code> constructor supports all options </li> <li> <code>--extension</code> is now an alias for <code>--watch-extensions</code> and affects non-watch-mode test runs as well. For example, to run only <code>test/*.coffee</code> (not <code>test/*.js</code>), you can do <code>mocha --require coffee-script/register --extensions coffee</code>. </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3552" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3552/hovercard">#3552</a>: <code>tap</code> reporter is now TAP13-capable (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a> & <a href="https://urls.greenkeeper.io/mollstam">@mollstam</a>) </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3535" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3535/hovercard">#3535</a>: Mocha's version can now be queried programmatically via public property <code>Mocha.prototype.version</code> (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>) </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3428" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3428/hovercard">#3428</a>: <code>xunit</code> reporter shows diffs (<a href="https://urls.greenkeeper.io/mlucool">@mlucool</a>) </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2529" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2529/hovercard">#2529</a>: <code>Runner</code> now emits a <code>retry</code> event when tests are retried (reporters can listen for this) (<a href="https://urls.greenkeeper.io/catdad">@catdad</a>) </li> <li> <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2962" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/2962/hovercard">#2962</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3111" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3111/hovercard">#3111</a>: In-browser notification support; warn about missing prereqs when <code>--growl</code> supplied (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>) </li> </ul> <h2><g-emoji class="g-emoji" alias="bug" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f41b.png">🐛</g-emoji> Fixes</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3737" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3737/hovercard">#3737</a>: Fix falsy values from options globals (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3707" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3707/hovercard">#3707</a>: Fix encapsulation issues for <code>Suite#_onlyTests</code> and <code>Suite#_onlySuites</code> (<a href="https://urls.greenkeeper.io/vkarpov15">@vkarpov15</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3711" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3711/hovercard">#3711</a>: Fix diagnostic messages dealing with plurality and markup of output (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3723" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3723/hovercard">#3723</a>: Fix "reporter-option" to allow comma-separated options (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3722" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3722/hovercard">#3722</a>: Fix code quality and performance of <code>lookupFiles</code> and <code>files</code> (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3650" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3650/hovercard">#3650</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3654" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3654/hovercard">#3654</a>: Fix noisy error message when no files found (<a href="https://urls.greenkeeper.io/craigtaub">@craigtaub</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3632" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3632/hovercard">#3632</a>: Tests having an empty title are no longer confused with the "root" suite (<a href="https://urls.greenkeeper.io/juergba">@juergba</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3666" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3666/hovercard">#3666</a>: Fix missing error codes (<a href="https://urls.greenkeeper.io/vkarpov15">@vkarpov15</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3684" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3684/hovercard">#3684</a>: Fix exiting problem in Node.js v11.7.0+ (<a href="https://urls.greenkeeper.io/addaleax">@addaleax</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3691" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3691/hovercard">#3691</a>: Fix <code>--delay</code> (and other boolean options) not working in all cases (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3692" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3692/hovercard">#3692</a>: Fix invalid command-line argument usage not causing actual errors (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3698" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3698/hovercard">#3698</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3699" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3699/hovercard">#3699</a>: Fix debug-related Node.js options not working in all cases (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3700" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3700/hovercard">#3700</a>: Growl notifications now show the correct number of tests run (<a href="https://urls.greenkeeper.io/outsideris">@outsideris</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3686" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3686/hovercard">#3686</a>: Avoid potential ReDoS when diffing large objects (<a href="https://urls.greenkeeper.io/cyjake">@cyjake</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3715" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3715/hovercard">#3715</a>: Fix incorrect order of emitted events when used programmatically (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3706" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3706/hovercard">#3706</a>: Fix regression wherein <code>--reporter-option</code>/<code>--reporter-options</code> did not support comma-separated key/value pairs (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li>Fix missing <code>mocharc.json</code> in published package (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3356" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3356/hovercard">#3356</a>: <code>--no-timeouts</code> and <code>--timeout 0</code> now does what you'd expect (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3475" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3475/hovercard">#3475</a>: Restore <code>--no-exit</code> option (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3570" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3570/hovercard">#3570</a>: Long-running tests now respect <code>SIGINT</code> (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2944" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2944/hovercard">#2944</a>: <code>--forbid-only</code> and <code>--forbid-pending</code> now "fail fast" when encountered on a suite (<a href="https://urls.greenkeeper.io/outsideris">@outsideris</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/1652" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/1652/hovercard">#1652</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2951" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2951/hovercard">#2951</a>: Fix broken clamping of timeout values (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2753" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2753/hovercard">#2753</a>: <code>start</code> and <code>end</code> events now emitted properly from <code>Runner</code> instance when using Mocha programmatically (<a href="https://urls.greenkeeper.io/outsideris">@outsideris</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2095" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2095/hovercard">#2095</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3521" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3521/hovercard">#3521</a>: Do not log <code>stdout:</code> prefix in browser console (<a href="https://urls.greenkeeper.io/Bamieh">@Bamieh</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3595" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3595/hovercard">#3595</a>: Fix mochajs.org deployment problems (<a href="https://urls.greenkeeper.io/papandreou">@papandreou</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3518" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3518/hovercard">#3518</a>: Improve <code>utils.isPromise()</code> (<a href="https://urls.greenkeeper.io/fabiosantoscode">@fabiosantoscode</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3320" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3320/hovercard">#3320</a>: Fail gracefully when non-extensible objects are thrown in async tests (<a href="https://urls.greenkeeper.io/fargies">@fargies</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2475" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/2475/hovercard">#2475</a>: XUnit does not duplicate test result numbers in "errors" and "failures"; "failures" will always be zero (<a href="https://urls.greenkeeper.io/mlucool">@mlucool</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3398" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3398/hovercard">#3398</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3598" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3598/hovercard">#3598</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3457" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3457/hovercard">#3457</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3617" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3617/hovercard">#3617</a>: Fix regression wherein <code>--bail</code> would not execute "after" nor "after each" hooks (<a href="https://urls.greenkeeper.io/juergba">@juergba</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3580" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3580/hovercard">#3580</a>: Fix potential exception when using XUnit reporter programmatically (<a href="https://urls.greenkeeper.io/Lana-Light">@Lana-Light</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/1304" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/1304/hovercard">#1304</a>: Do not output color to <code>TERM=dumb</code> (<a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a>)</li> </ul> <h2><g-emoji class="g-emoji" alias="book" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f4d6.png">📖</g-emoji> Documentation</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3525" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3525/hovercard">#3525</a>: Improvements to <code>.github/CONTRIBUTING.md</code> (<a href="https://urls.greenkeeper.io/markowsiak">@markowsiak</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3466" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3466/hovercard">#3466</a>: Update description of <code>slow</code> option (<a href="https://urls.greenkeeper.io/finfin">@finfin</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3405" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3405/hovercard">#3405</a>: Remove references to bower installations (<a href="https://urls.greenkeeper.io/goteamtim">@goteamtim</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3361" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3361/hovercard">#3361</a>: Improvements to <code>--watch</code> docs (<a href="https://urls.greenkeeper.io/benglass">@benglass</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3136" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3136/hovercard">#3136</a>: Improve docs around globbing and shell expansion (<a href="https://urls.greenkeeper.io/akrawchyk">@akrawchyk</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/2819" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/2819/hovercard">#2819</a>: Update docs around skips and hooks (<a href="https://urls.greenkeeper.io/bannmoore">@bannmoore</a>)</li> <li>Many improvements by <a href="https://urls.greenkeeper.io/outsideris">@outsideris</a></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3652" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3652/hovercard">#3652</a>: Switch from Jekyll to Eleventy (<a href="https://urls.greenkeeper.io/Munter">@Munter</a>)</li> </ul> <h2><g-emoji class="g-emoji" alias="nut_and_bolt" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f529.png">🔩</g-emoji> Other</h2> <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3677" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3677/hovercard">#3677</a>: Add error objects for createUnsupportedError and createInvalidExceptionError (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3733" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3733/hovercard">#3733</a>: Removed unnecessary processing in post-processing hook (<a href="https://urls.greenkeeper.io/wanseob">@wanseob</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3730" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3730/hovercard">#3730</a>: Update nyc to latest version (<a href="https://urls.greenkeeper.io/coreyfarrell">@coreyfarrell</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3648" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3648/hovercard">#3648</a>, <a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3680" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3680/hovercard">#3680</a>: Fixes to support latest versions of <a href="https://npm.im/unexpected" rel="nofollow">unexpected</a> and <a href="https://npm.im/unexpected-sinon" rel="nofollow">unexpected-sinon</a> (<a href="https://urls.greenkeeper.io/sunesimonsen">@sunesimonsen</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3638" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3638/hovercard">#3638</a>: Add meta tag to site (<a href="https://urls.greenkeeper.io/MartijnCuppens">@MartijnCuppens</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3653" data-hovercard-type="pull_request" data-hovercard-url="/mochajs/mocha/pull/3653/hovercard">#3653</a>: Fix parts of test suite failing to run on Windows (<a href="https://urls.greenkeeper.io/boneskull">@boneskull</a>)</li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/issues/3557" data-hovercard-type="issue" data-hovercard-url="/mochajs/mocha/issues/3557/hovercard">#3557</a>: Use <code>ms</code> userland module instead of hand-rolled solution (<a href="https://urls.greenkeeper.io/gizemkeser">@gizemkeser</a>)</li> <li>Many CI fixes and other refactors by <a href="https://urls.greenkeeper.io/plroebuck">@plroebuck</a></li> <li>Test refactors by <a href="https://urls.greenkeeper.io/outsideris">@outsideris</a></li> </ul> </details> <details> <summary>Commits</summary> The new version differs by 209 commits ahead by 209, behind by 39. <ul> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/42303e2acba217af554294b1174ee53b5627cc33"><code>42303e2</code></a> <code>Release v6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/a553ca70287f407abd4a82180e4a1155b8730756"><code>a553ca7</code></a> <code>punctuation updates for changelog v6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/c7107926b3a546960e841b0339bf4a3b85170c4c"><code>c710792</code></a> <code>grammar updates for changelog v6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/9f9293a0db44ce41e1bd9cc38d68e3d7a1010f41"><code>9f9293a</code></a> <code>update changelog for v6.0.0</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/a540eb06f23135db563a6b2bd2e0b3b51583fde7"><code>a540eb0</code></a> <code>remove "projects" section from MAINTAINERS.md [ci skip]</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/52b5c42c3dda8c386735969642843bd1129a4562"><code>52b5c42</code></a> <code>Uppercased JSON reporter name in <code>describe</code> title (#3739)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/82307fbf9bfa7cd72042facd1d42fb108257100c"><code>82307fb</code></a> <code>Fix <code>.globals</code> to remove falsy values (#3737)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/56dc28e62f63903632d5fe4169b52cb2cdb5f7ea"><code>56dc28e</code></a> <code>Remove unnecessary post-processing code having no effect; closes #3708 (#3733)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/16b4281b6e86d93e959a37f830a349c0542d968a"><code>16b4281</code></a> <code>Documentation updates (#3728)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/5d9d3eb665825ea69435388f5776150f40c844be"><code>5d9d3eb</code></a> <code>Update nyc</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/118c9aeab5b6192d627b0b369e43584ab8f9f0b7"><code>118c9ae</code></a> <code>Refactor out usages of Suite#_onlyTests and Suite#_onlyTests (#3689) (#3707)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/0dacd1fb0067e40f8567653f828f677022e4fb89"><code>0dacd1f</code></a> <code>Add ability to unload files from <code>require</code> cache (redux) (#3726)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/66a52f25cafd266ab3cce2db975a560a695ecae9"><code>66a52f2</code></a> <code>update release steps [ci skip]</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/45ae014d0baba97b4b50b37ae526e1b50a9334e9"><code>45ae014</code></a> <code>Refactor <code>lookupFiles</code> and <code>files</code> (#3722)</code></li> <li><a href="https://urls.greenkeeper.io/mochajs/mocha/commit/94c932095b4b8e8a7a5d9dde93ad2172d95f5ebe"><code>94c9320</code></a> <code>fix --reporter-option to allow comma-separated options; closes #3706</code></li> </ul> There are 209 commits in total. See the <a href="https://urls.greenkeeper.io/mochajs/mocha/compare/5bd33a0ba201d227159759e8ced86756595b0c54...42303e2acba217af554294b1174ee53b5627cc33">full diff</a> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴

mlucool mentioned this pull request Sep 12, 2016

fix: Dont count xunit failures as errors peerigon/xunit-file#27

Merged

boneskull added type: bug a defect, confirmed by a maintainer area: reporters involving a specific reporter status: waiting for author waiting on response from OP - more information needed unconfirmed labels Sep 17, 2016

boneskull added pr-needs-work and removed status: waiting for author waiting on response from OP - more information needed unconfirmed labels Sep 18, 2016

boneskull closed this Apr 7, 2018

outsideris reopened this Apr 8, 2018

boneskull suggested changes Apr 12, 2018

View reviewed changes

boneskull removed the pr-needs-work label Apr 12, 2018

boneskull force-pushed the master branch 2 times, most recently from 4547268 to 7613521 Compare May 4, 2018 16:47

craigtaub added semver-minor implementation requires increase of "minor" version number; "features" and removed semver-minor implementation requires increase of "minor" version number; "features" labels Dec 2, 2018

mlucool force-pushed the patch-2 branch from 92722c9 to c837506 Compare December 4, 2018 00:46

mlucool force-pushed the patch-2 branch from df93ec4 to feb8a5e Compare December 4, 2018 22:37

craigtaub reviewed Dec 11, 2018

View reviewed changes

craigtaub added the semver-major implementation requires increase of "major" version number; "breaking changes" label Dec 11, 2018

mlucool force-pushed the patch-2 branch from feb8a5e to f99a36c Compare December 17, 2018 19:57

Dont count xunit failures as errors

c03d248

mlucool force-pushed the patch-2 branch from f99a36c to c03d248 Compare December 17, 2018 20:47

boneskull approved these changes Dec 18, 2018

View reviewed changes

boneskull merged commit 89169cd into mochajs:master Dec 18, 2018

boneskull added a commit that referenced this pull request Dec 18, 2018

add #2475 [ci skip]

7ea51c6

boneskull added a commit that referenced this pull request Dec 18, 2018

add #2475 [ci skip]

89c74ef

boneskull added this to the v6.0.0 milestone Dec 19, 2018

boneskull added a commit that referenced this pull request Dec 19, 2018

add #2475 [ci skip]

56d3bf3

boneskull added a commit that referenced this pull request Dec 28, 2018

add #2475 [ci skip]

9474f1e

This was referenced Oct 26, 2019

[Snyk] Upgrade mocha from 4.1.0 to 6.2.1 ajesse11x/marketplace#5

Open

[Snyk] Upgrade mocha from 2.5.3 to 6.2.1 ajesse11x/kompose#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dont count xunit failures as errors #2475

Dont count xunit failures as errors #2475

mlucool commented Sep 12, 2016

boneskull commented Sep 17, 2016

boneskull commented Sep 17, 2016

mlucool commented Sep 17, 2016

boneskull commented Sep 18, 2016

mlucool commented Sep 19, 2016

mlucool commented Oct 1, 2016

mlucool commented Feb 28, 2017

mlucool commented Mar 10, 2017

mlucool commented Jul 12, 2017

boneskull commented Apr 7, 2018

mlucool commented Apr 8, 2018

boneskull left a comment

craigtaub commented Dec 2, 2018 •

edited

Loading

mlucool commented Dec 4, 2018

craigtaub Dec 11, 2018 •

edited

Loading

mlucool Dec 17, 2018

boneskull commented Dec 18, 2018

boneskull commented Dec 18, 2018

Dont count xunit failures as errors #2475

Dont count xunit failures as errors #2475

Conversation

mlucool commented Sep 12, 2016

boneskull commented Sep 17, 2016

boneskull commented Sep 17, 2016

mlucool commented Sep 17, 2016

boneskull commented Sep 18, 2016

mlucool commented Sep 19, 2016

mlucool commented Oct 1, 2016

mlucool commented Feb 28, 2017

mlucool commented Mar 10, 2017

mlucool commented Jul 12, 2017

boneskull commented Apr 7, 2018

mlucool commented Apr 8, 2018

boneskull left a comment

Choose a reason for hiding this comment

craigtaub commented Dec 2, 2018 • edited Loading

mlucool commented Dec 4, 2018

craigtaub Dec 11, 2018 • edited Loading

Choose a reason for hiding this comment

mlucool Dec 17, 2018

Choose a reason for hiding this comment

boneskull commented Dec 18, 2018

boneskull commented Dec 18, 2018

craigtaub commented Dec 2, 2018 •

edited

Loading

craigtaub Dec 11, 2018 •

edited

Loading