Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use runMocha() for what we're using it for #2595

Closed
boneskull opened this issue Nov 24, 2016 · 2 comments
Closed

don't use runMocha() for what we're using it for #2595

boneskull opened this issue Nov 24, 2016 · 2 comments
Labels
status: accepting prs Mocha can use your help with this one!

Comments

@boneskull
Copy link
Contributor

runMocha() in module test/integration/helpers is suited to testing raw reporter output, but unfortunately it's being used in a couple places to check failures, passes, errors, etc.

Use runMochaJSON() instead if we're not testing raw reporter output.
@boneskull boneskull added status: accepting prs Mocha can use your help with this one! qa labels Nov 24, 2016
@soobing soobing mentioned this issue Oct 19, 2019
Merged
@soobing
Copy link
Contributor

soobing commented Oct 27, 2019

This issue should be closed.

@outsideris
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Mocha can use your help with this one!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@outsideris @boneskull @soobing