Reporter tests affected by shallow cloning

[plroebuck]

Description

While updating our reporter test code, it has been discovered that many tests are restoring aspects of the tested objects due to use of shallow cloning. Typically, the test code makes a copy of the affected object, mutates it temporarily, then restores it. Problem is that making a copy via assignment of an object does not work protect its properties, and those "twiddled" properties are still present in the original when restored. We need a "deep clone" method, and then to apply it to all reporter specs.

While not evaluated elsewhere (yet), it is almost certain this problem is far more widespread.

Versions

Mocha 5.2 (past & future)

[boneskull]

Do you have an example...?

[outsideris]

Maybe this one?

[plroebuck]

From the article How To Copy Objects in JavaScript:

• cloner - An ES5+ compatible utility to deep or shallow copy and merge objects.

[boneskull]

Couldn't this just be solved by using e.g., Sinon?