xdescribe executes the code

[uluhonolulu]

Prerequisites

• [ x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
• Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code. (doesn't apply here)
• 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself (doesn't apply here)
• Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend avoiding the use of globally installed Mocha. (doesn't apply here)

Description

The code that runs inside an xdescribe block is executed, although it's not supposed to.

Steps to Reproduce

xdescribe('hey', () => {
    console.log("YOOO")
});

Expected behavior:
No console output

Actual behavior:
"YOOO" in the console output

Reproduces how often:
Always

Versions

• The output of mocha --version and node node_modules/.bin/mocha --version:
  5.2.0
• The output of node --version:
  v8.11.2
• The version and architecture of your operating system:
  Windows 7
• Your shell (bash, zsh, PowerShell, cmd, etc.):
  VSCode terminal

[craigtaub]

Not quite sure if this is by design or not.
Docs suggest should be executed but I think it might just be incorrect docs.
See .only on https://mochajs.org/#exclusive-tests says "Note: All nested suites will still be executed.". Think the same deal.

[uluhonolulu]

@craigtaub I couldn't find any docs for xdescribe -- where did you see that "Docs suggest should be executed"?

[craigtaub]

@uluhonolulu sorry i meant "not" executed. xdescribe same as .skip..

[boneskull]

Yes, this is by design. The reasoning is that .skip is not the only way to control which suites / tests are executed. We have --grep, --fgrep and .only, and they all have precedence. The only way to ensure multiple options are respected (though the greplike options are mutually exclusive now) is to execute all suites.