Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sponsors logo more readable when logo is white in homepage #3736

Closed
outsideris opened this issue Feb 16, 2019 · 8 comments · Fixed by #3988
Closed

make sponsors logo more readable when logo is white in homepage #3736

outsideris opened this issue Feb 16, 2019 · 8 comments · Fixed by #3988
Labels
area: documentation anything involving docs or mochajs.org area: website involving mochajs.org, but not necessarily involving docs

Comments

@outsideris
Copy link
Contributor

outsideris commented Feb 16, 2019

In homepage, some sponsors's logo is white. So, people can't realize who is support us.
We should make them to people see the logo well like background color or shadow.

2019-02-16 18 02 34

@outsideris outsideris added the area: documentation anything involving docs or mochajs.org label Feb 16, 2019
@plroebuck plroebuck added the area: website involving mochajs.org, but not necessarily involving docs label Feb 18, 2019
@boneskull boneskull self-assigned this Feb 25, 2019
@boneskull
Copy link
Contributor

I'll ask OC about this.

@znarf
Copy link
Contributor

znarf commented Feb 25, 2019

It’s tricky. The simplest would be to contact the sponsor to upload the white logo with a background color, or a non-white logo that works well on white backgrounds.

@boneskull boneskull removed their assignment Feb 27, 2019
@boneskull
Copy link
Contributor

Thanks @znarf. I asked (in Slack):

is that something OC could do for us? are logos unique to each OC, or unique to a company?

@outsideris
Copy link
Contributor Author

There were some changes for background in OC. It looks ugly with our website.

스크린샷 2019-06-04 12 45 30

@znarf
Copy link
Contributor

znarf commented Jun 4, 2019

@outsideris Sorry for the breaking change, we effectively shipped a major refactoring which is related to that.

I think you can avoid that behavior by switching from .jpg to .png while including these images. Before: https://opencollective.com/mochajs/backer/1/avatar.jpg After: https://opencollective.com/mochajs/backer/1/avatar.png

On our side, we'll check if there is a simple fix to have the background default to white when using the jpg format.

@outsideris
Copy link
Contributor Author

@znarf Thank you. We will fix them.

@znarf
Copy link
Contributor

znarf commented Jun 7, 2019

I fixed the black background issue. opencollective/opencollective-images#70 It's being deployed. Still doesn't hurt to migrate to png.

@outsideris
Copy link
Contributor Author

@znarf Thank you. It looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org area: website involving mochajs.org, but not necessarily involving docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants