fix: check if module.paths really exists #4194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
module.paths
was not defined when Mocha was run in an serverless environment. Probably due to the absence ofnode_modules
folder. I had bundled the test using a bundler.I added a check to make sure it doesn't throw an error.
Alternate Designs
Not sure if there are any other alternatives but open to suggestions.
Why should this be in core?
I don't think userland should mock
module.paths
.Benefits
It would not throw an error during the execution of tests in a serverless environment.
Possible Drawbacks
I don't see any.
Applicable issues
Fixes #2505
This should be a bug fix