Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In watch mode, the watcher crashed when there are syntax errors in test files during
require('test file')
.It only happens in serial mode and Node v15+.
This
try - catch
statement removed when we introduce parallel mode.I think we need
try - catch
here.And I added test cases for the crash case to prevent regression.
Why should this be in core?
Watching should be worked.
Benefits
Users can use watch mode when the test code is broken.
Applicable issues
Fix #4580